-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Added Random Walks COO convertor and profiling #1531
[ENH] Added Random Walks COO convertor and profiling #1531
Conversation
Merge latest release 0.17
Merge latest branch-0.18
Update forked branch-0.18
Update forked branch-0.18 from release
Update branch-0.19 from release
update forked from release branch-0.19
Merge from release branch-0.19
Merge latest rapidsai:branch-0.19 into aschaffer:branch-0.19
…lgorithms.hpp and into path_retrieval.hpp.
… executable, fixed bug in utility function for processing RMM CLI options.
Codecov Report
@@ Coverage Diff @@
## branch-0.20 NVIDIA/thrust#1531 +/- ##
==============================================
Coverage ? 60.26%
==============================================
Files ? 73
Lines ? 3214
Branches ? 0
==============================================
Hits ? 1937
Misses ? 1277
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once comment... we can address it later.
@@ -782,3 +782,121 @@ TEST_F(RandomWalksPrimsTest, SimpleGraphRandomWalk) | |||
|
|||
ASSERT_TRUE(test_all_paths); | |||
} | |||
|
|||
TEST(RandomWalksSpecialCase, SingleRandomWalk) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this can't be rw_low_level_test.cpp
? We've been trying to migrate to .cpp files where possible since they compile faster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. check_col_indices()
calls thrust
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth considering migrating that to a utility file at some point.
Note we should probably use thrust::count_if
in that function due to this
https://github.com/NVIDIA/thrust/issues/1016
@gpucibot merge |
This PR is used to track enhancements to Random Walks functionality:
experimental
sub-dirs;