Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge from release branch-0.19 #43

Merged
merged 19 commits into from
Mar 20, 2021
Merged

Conversation

aschaffer
Copy link
Owner

aschaffer/branch-0.19 <- rapidsai/branch-0.19

seunghwak and others added 19 commits March 1, 2021 19:02
- [x] Add tests using graphs with isolated vertices
- [x] Add personalized PageRank tests
- [x] Test code refactoring
- [x] Create libcugraphtestutil.a

This PR fixes FIXMEs added in #1361 to address #1136

Authors:
  - Seunghwa Kang (@seunghwak)

Approvers:
  - Rick Ratzel (@rlratzel)
  - Andrei Schaffer (@aschaffer)
  - Brad Rees (@BradReesWork)

URL: #1419
Prepare Changelog for Automation (#1433)

This PR prepares the changelog to be automatically updated during releases. The contents of the pre-release body linked in this PR will be copied into CHANGELOG.md at release time.

Authors:
  - AJ Schmidt (@ajschmidt8)

Approvers:
  - Dillon Cullinan (@dillon-cullinan)

URL: #1433
Close #1329 (with #1401)

Authors:
  - Seunghwa Kang (@seunghwak)

Approvers:
  - Brad Rees (@BradReesWork)
  - Alex Fender (@afender)
  - Andrei Schaffer (@aschaffer)

URL: #1411
#1425)

A recent change caused the `setup.py` running in a clean checkout to fail unless either `RAFT_PATH` or `CUGRAPH_BUILD_PATH` were set.  These are typically set if you run the build scripts, but if you try running the build steps individually by hand the script would fail unless you set one of these environment variables correctly.

This PR fixes the default path (if neither environment variable is specified) to construct the proper location for looking up raft.

Closes #1428

Authors:
  - Chuck Hastings (@ChuckHastings)

Approvers:
  - Rick Ratzel (@rlratzel)
  - Brad Rees (@BradReesWork)

URL: #1425
…ctor & std::vector, respectively. (#1421)

- [x] Replace rmm::device_vector with rmm::device_uvector for better concurrency in multi-stream executions
- [x] Replace thrust::host_vector with std::vector

This PR partially addresses #1390

Authors:
  - Seunghwa Kang (@seunghwak)

Approvers:
  - Alex Fender (@afender)

URL: #1421
Closes #1407

Authors:
  - @Iroy30

Approvers:
  - Alex Fender (@afender)
  - Brad Rees (@BradReesWork)

URL: #1436
We have long needed a developer's guide.  This PR creates one.  The expectation is that this document will be adapted over time.

I have copied the version from cuDF, edited things to make it cuGraph focused.  There are documentation holes here that will need to eventually be filled in.  However, it's probably useful to get something with holes in it that is approved so we can move forward with some documented standard.

Authors:
  - Chuck Hastings (@ChuckHastings)

Approvers:
  - Rick Ratzel (@rlratzel)
  - Brad Rees (@BradReesWork)

URL: #1431
- Stream synchronization behavior: switched to per-thread default stream instead of the legacy default stream
- Update raft tag
- EgoNet upgrade to use `uvector` instead of `device_vector`
- EgoNet upgrade to execute on a different stream for each seed
- Perf analysis timers/app for EgoNet

Concurrency is limited by the number of available blocks on the device. Thrust-based codes may request a lot of blocks without a way to control this. In practice, smaller graphs leverage concurrency better than larger ones where tasks may end up waiting for available resources.

We may wait on #1407 before reconciling and merging this
Close #957

Authors:
  - Alex Fender (@afender)

Approvers:
  - Seunghwa Kang (@seunghwak)
  - Andrei Schaffer (@aschaffer)

URL: #1435
…P to use the new R-mat graph generator (#1438)

- [x] Refactor cuGraph C++ test library
- [x] Add a utility function to create a graph object from the R-mat generator
- [x] Update C++ MG PageRank and SG PageRank, Katz Centrality, BFS, and SSSP tests to use the new R-mat graph generator

This partially addresses #1382 and is a per-requsite for graph primitives performance optimization.

Authors:
  - Seunghwa Kang (@seunghwak)

Approvers:
  - Andrei Schaffer (@aschaffer)
  - Chuck Hastings (@ChuckHastings)
  - Brad Rees (@BradReesWork)

URL: #1438
upgraded FAISS to version 1.7

closes #1440

Authors:
  - Brad Rees (@BradReesWork)
  - Rick Ratzel (@rlratzel)

Approvers:
  - Alex Fender (@afender)
  - AJ Schmidt (@ajschmidt8)
  - Rick Ratzel (@rlratzel)

URL: #1444
update the environment to use NCCL 2.8.4

Authors:
  - Brad Rees (@BradReesWork)

Approvers:
  - AJ Schmidt (@ajschmidt8)
  - @seunghwakang
  - Seunghwa Kang (@seunghwak)
  - Rick Ratzel (@rlratzel)

URL: #1445
The tag used for pre-releases was recently changed, so this PR updates the link in the changelog.

Authors:
  - AJ Schmidt (@ajschmidt8)

Approvers:
  - Jordan Jacobelli (@Ethyling)

URL: #1446
Authors:
  - @Iroy30

Approvers:
  - Seunghwa Kang (@seunghwak)
  - Andrei Schaffer (@aschaffer)

URL: #1427
…gpuid_and_shuffle (#1434)

Related to addressing Issue #1381.

Fix bugs in MNMG graph primitives to support Louvain.

Authors:
  - Seunghwa Kang (@seunghwak)

Approvers:
  - Chuck Hastings (@ChuckHastings)
  - Brad Rees (@BradReesWork)

URL: #1434
A recent update to numba 0.53 in CI broke this script and caused CI failures. This makes the script compatible with both pre and post numba 0.53 versions.

Tested in a local env with numba 0.53 installed.

Authors:
  - Rick Ratzel (@rlratzel)

Approvers:
  - Alex Fender (@afender)
  - Brad Rees (@BradReesWork)
  - Chuck Hastings (@ChuckHastings)
  - AJ Schmidt (@ajschmidt8)

URL: #1455
After rapidsai/rmm#725 is merged, this PR updates cuspatial to eliminate passing literal values to device_uvector::set_element_async.

Companion PR to rapidsai/cuspatial#367

Authors:
  - Mark Harris (@harrism)

Approvers:
  - Seunghwa Kang (@seunghwak)
  - Alex Fender (@afender)
  - Andrei Schaffer (@aschaffer)

URL: #1453
* added Hungarian to api.rst
* fixed missing examples
* fixed syntax

Authors:
  - Brad Rees (@BradReesWork)

Approvers:
  - Rick Ratzel (@rlratzel)
  - Alex Fender (@afender)

URL: #1448
…ript code from test script to gpu build script (#1468)

* Removed unused dependencies from the `libcugraph` recipe.  This is motivated by the CuPy project to integrate `libcugraph` as the graph analytics backend with minimal extra dependencies ( cupy/cupy#4219, cupy/cupy#2431, cupy/cupy#4054 )
* Moved non-test script code from test script to gpu build script. The `FIXME` addressed for this was added after discussing with @raydouglass earlier, and will allow any Project Flash failures to fail the build immediately instead of attempting to then run tests.
* Removed unused cudf lib reference from test cmake file.

Tested by doing a successful local `conda build` of the recipe.

Authors:
  - Rick Ratzel (@rlratzel)

Approvers:
  - Brad Rees (@BradReesWork)
  - Chuck Hastings (@ChuckHastings)
  - AJ Schmidt (@ajschmidt8)

URL: #1468
add datasets to test self-loops, string vertex IDs and isolated vertices
Update README
closes #1214

Authors:
  - Joseph Nke (@jnke2016)

Approvers:
  - Brad Rees (@BradReesWork)
  - Rick Ratzel (@rlratzel)

URL: #1441
@aschaffer aschaffer merged commit e5042fc into aschaffer:branch-0.19 Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants