-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to update calls to cuDF Series
ctors when calling with a Buffer
type
#1908
Comments
…r handling non-renumbered Graphs (#1901) * Updates for latest cuDF which changes how `Series` objects are constructed from `Buffer` types. * Updated `ci/gpu/build.sh` to add the conda env `bin` dir to `PATH`, since it was not finding the correct `cmake` during a local run. * Cleaned up various cython imports. * Added test and bug fix to ensure a graph that has not been renumbered is handled correctly by `cugraph.subgraph()`. * Updated `pytest.ini` for users that don't have the required extra pytest plugins installed, left comments in place to for users to re-enable. * Minor test and code cleanup. closes #1908 closes #1899 _Note: this PR was originally intended to be two PRs: one for the `subgraph` bug fix, and another for the `cudf.Series` updates. I accidentally pushed the Series updates to the wrong branch, hence this combined PR. I can separate them if reviewing is too difficult._ Authors: - Rick Ratzel (https://github.com/rlratzel) Approvers: - Chuck Hastings (https://github.com/ChuckHastings) - Brad Rees (https://github.com/BradReesWork) - AJ Schmidt (https://github.com/ajschmidt8) URL: #1901
@rlratzel @ChuckHastings I'm glad this was able to get resolved relatively quickly. As we discussed today I'll plan to be more conservative with future changes, but I think it would also be useful for us to meet at some point to get a sense of what parts of cuDF's API cuGraph might be using. There are many aspects that we would consider internal and may eventually want to hide, but some of them may need to stay public or at least stable for other RAPIDS libraries to use. |
I'll yield to @rlratzel on most of these issues. He leads the python side of things. I believe we are going to dramatically refactor/simplify much of our interface over the next few months. It seems like a natural time to review all points where we touch cudf as the python side is refactored. I think much of what is there was copied from python/cython in cudf at the time when we needed to implement something. I have no doubt that there are more examples where we are doing things using techniques that are not preferred. |
OK sounds good @rlratzel I don't know if we necessarily need to have a dedicated conversation for this, that's up to you (perhaps after you've planned more of your refactoring). I'll keep alerting you (and marking relevant PRs) as we make further internal changes in cuDF that may impact you. |
rapidsai/cudf#9370 changed support for how
Series
object are to be constructed withBuffer
objects.For instance, this example is no longer supported:
The supported pattern is now:
cc @ChuckHastings @vyasr
The text was updated successfully, but these errors were encountered: