Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous column cleanup #9370

Merged
merged 17 commits into from
Oct 21, 2021

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Oct 5, 2021

This PR contains an array of minor improvements to column classes to improve readability and simplify some implementations.

@vyasr vyasr added 3 - Ready for Review Ready for review by team code quality Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 5, 2021
@vyasr vyasr added this to the CuDF Python Refactoring milestone Oct 5, 2021
@vyasr vyasr self-assigned this Oct 5, 2021
@vyasr vyasr requested a review from a team as a code owner October 5, 2021 03:20
@vyasr vyasr requested review from cwharris and shwina October 5, 2021 03:20
@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #9370 (8de897f) into branch-21.12 (ab4bfaa) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9370      +/-   ##
================================================
- Coverage         10.79%   10.67%   -0.12%     
================================================
  Files               116      117       +1     
  Lines             18869    19705     +836     
================================================
+ Hits               2036     2104      +68     
- Misses            16833    17601     +768     
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.90% <0.00%> (-1.21%) ⬇️
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52b7a9e...8de897f. Read the comment docs.

Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Glad to see all the as_column->build_column changes

Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments. Also not familiar with the changes in test_dlpack, can you explain a bit?

python/cudf/cudf/core/column/numerical.py Show resolved Hide resolved
python/cudf/cudf/core/column/numerical.py Outdated Show resolved Hide resolved
@isVoid
Copy link
Contributor

isVoid commented Oct 19, 2021

Looks great to me! Glad to see all the as_column->build_column changes

Also glad to see isna -> isnull changes

@vyasr
Copy link
Contributor Author

vyasr commented Oct 20, 2021

Just some minor comments. Also not familiar with the changes in test_dlpack, can you explain a bit?

I just removed ColumnBase.to_dlpack entirely, so the corresponding tests had to be removed as well. We never need to convert a column into a dlpack tensor, only higher-level objects (Frames), so there's no reason to support this.

@vyasr vyasr requested a review from isVoid October 21, 2021 00:22
@shwina
Copy link
Contributor

shwina commented Oct 21, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e4e4870 into rapidsai:branch-21.12 Oct 21, 2021
@vyasr vyasr deleted the refactor/column_cleanup branch January 14, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants