-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous column cleanup #9370
Miscellaneous column cleanup #9370
Conversation
a495b2b
to
f1de8bb
Compare
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9370 +/- ##
================================================
- Coverage 10.79% 10.67% -0.12%
================================================
Files 116 117 +1
Lines 18869 19705 +836
================================================
+ Hits 2036 2104 +68
- Misses 16833 17601 +768
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Glad to see all the as_column
->build_column
changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor comments. Also not familiar with the changes in test_dlpack
, can you explain a bit?
Also glad to see |
I just removed |
@gpucibot merge |
This PR contains an array of minor improvements to column classes to improve readability and simplify some implementations.