Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disabling problematic test in parquet writer #9230

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Temporarily disabling problematic test in parquet writer #9230

merged 1 commit into from
Sep 15, 2021

Conversation

devavret
Copy link
Contributor

@devavret devavret commented Sep 14, 2021 •
edited
Loading

There is a bug in parquet writer that shows up in one pytest.
Disabling this test to unblock CI for other PRs.

Related to #9231

@devavret devavret requested a review from a team as a code owner September 14, 2021 19:38
@github-actions github-actions bot added the Python Affects Python cuDF API. label Sep 14, 2021
@brandon-b-miller
Copy link
Contributor

Is there an open issue tracking the bug mentioned here?

@codecov
Copy link

codecov bot commented Sep 14, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@e27675a). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 86a845c differs from pull request most recent head 90c0e21. Consider uploading reports for the commit 90c0e21 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9230   +/-   ##
===============================================
  Coverage                ?   10.84%           
===============================================
  Files                   ?      115           
  Lines                   ?    19176           
  Branches                ?        0           
===============================================
  Hits                    ?     2080           
  Misses                  ?    17096           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e27675a...90c0e21. Read the comment docs.

@devavret
Copy link
Contributor Author

Is there an open issue tracking the bug mentioned here?

Not yet. This comes from a slack thread where CI issues were being discussed.

@devavret devavret added bug Something isn't working non-breaking Non-breaking change labels Sep 14, 2021
@vyasr
Copy link
Contributor

vyasr commented Sep 15, 2021

I think this PR is probably worth getting merged ASAP to unblock CI since it is randomly forcing people to rerun tests, but it probably is worth opening an issue in case this turns out to be something that we can reproduce? I don't know if it really is a CI bug or just an intermittent problem that arises with a specific CUDA/Python/OS combination. Based on CI it was Ubuntu 18.04, CUDA 11.2, Python 3.8 I believe.

@devavret
Copy link
Contributor Author

I think this PR is probably worth getting merged ASAP to unblock CI since it is randomly forcing people to rerun tests, but it probably is worth opening an issue in case this turns out to be something that we can reproduce? I don't know if it really is a CI bug or just an intermittent problem that arises with a specific CUDA/Python/OS combination. Based on CI it was Ubuntu 18.04, CUDA 11.2, Python 3.8 I believe.

I believe it's a problem with writing an all null dataframe to parquet in Pascal. I found that the other two CI machines have Volta and Ampere.

@devavret
Copy link
Contributor Author

rerun tests

@devavret
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 651ec49 into rapidsai:branch-21.10 Sep 15, 2021
devavret added a commit to devavret/cudf that referenced this pull request Oct 5, 2021
@devavret
Fix the crash in stats code
ebd7ae4 
stat.(min/max)_value.str_val.length is used in calculating allocation size for page/stripe headers. Not zero initializing stat caused these values to be garbage.
Also re-enable the pytest that was disabled in rapidsai#9230
@devavret devavret mentioned this pull request Oct 5, 2021
Merged
rapids-bot bot pushed a commit that referenced this pull request Oct 5, 2021
@devavret
Fix the crash in stats code (#9368)
fe04d21 
`stat.(min/max)_value.str_val.length` is used in calculating allocation size for page/stripe headers. Not zero initializing stat caused these values to be garbage.
Also re-enabled the pytest that was disabled in #9230

Fixes #9231

Authors:
  - Devavret Makkar (https://github.com/devavret)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Mike Wilson (https://github.com/hyperbolic2346)
  - https://github.com/brandon-b-miller
  - Elias Stehle (https://github.com/elstehle)

URL: #9368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@marlenezw marlenezw Awaiting requested review from marlenezw

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devavret @brandon-b-miller @vyasr