Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Parquet writer pytest intermittently fails CI #9231

Closed
devavret opened this issue Sep 15, 2021 · 1 comment · Fixed by #9368
Closed

[BUG] Parquet writer pytest intermittently fails CI #9231

devavret opened this issue Sep 15, 2021 · 1 comment · Fixed by #9368
Assignees
@devavret
Labels
bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. tests Unit testing for project

Comments

@devavret
Copy link
Contributor

The pytest cudf.tests.test_parquet.test_parquet_writer_nulls_pandas_read[1] intermittently fails CI with a cudaErrorIllegalAddress error.

The failure is always seen in Ubuntu 18.04, CUDA 11.2, Python 3.8.
@devavret devavret added bug Something isn't working Needs Triage Need team to review and classify libcudf Affects libcudf (C++/CUDA) code. cuIO cuIO issue labels Sep 15, 2021
@devavret
Copy link
Contributor Author

The failure is always seen in Ubuntu 18.04, CUDA 11.2, Python 3.8.

This particular job runs on a machine with Pascal. The other two similar jobs runs on machines using Volta and Ampere.

@devavret devavret self-assigned this Sep 15, 2021
@devavret devavret mentioned this issue Sep 15, 2021
Merged
@beckernick beckernick added Python Affects Python cuDF API. tests Unit testing for project and removed Needs Triage Need team to review and classify labels Sep 15, 2021
rapids-bot bot pushed a commit that referenced this issue Sep 15, 2021
@devavret
Temporarily disabling problematic test in parquet writer (#9230)
651ec49 
There is a bug in parquet writer that shows up in one pytest.
Disabling this test to unblock CI for other PRs.

Related to #9231

Authors:
  - Devavret Makkar (https://github.com/devavret)

Approvers:
  - https://github.com/brandon-b-miller

URL: #9230
@devavret devavret mentioned this issue Oct 5, 2021
Merged
@rapids-bot rapids-bot bot closed this as completed in #9368 Oct 5, 2021
rapids-bot bot pushed a commit that referenced this issue Oct 5, 2021
@devavret
Fix the crash in stats code (#9368)
fe04d21 
`stat.(min/max)_value.str_val.length` is used in calculating allocation size for page/stripe headers. Not zero initializing stat caused these values to be garbage.
Also re-enabled the pytest that was disabled in #9230

Fixes #9231

Authors:
  - Devavret Makkar (https://github.com/devavret)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Mike Wilson (https://github.com/hyperbolic2346)
  - https://github.com/brandon-b-miller
  - Elias Stehle (https://github.com/elstehle)

URL: #9368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devavret devavret

Labels
bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the crash in stats code devavret/cudf
2 participants
@devavret @beckernick