Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty child columns in row_bit_count() #8791

Merged
merged 3 commits into from
Jul 21, 2021
Merged

Handle empty child columns in row_bit_count() #8791

merged 3 commits into from
Jul 21, 2021

Commits on Jul 20, 2021

  1. Handle empty child columns in row_bit_count(): 

    `row_bit_count()` handles string and list inputs by computing the sizes
of the offsets, and that of the elements in the underlying child
column.
For cases where the child column is empty (e.g. where the input string/
list column contains only nulls), row_bit_count() erroneously attempts
to read the contents of the empty `offsets` and `child.data()`, leading
to bad reads and crashes.
This commit allows `row_bit_count()` to identify empty child row spans
as having `0` size. It also correctly handles empty child columns.
    @mythrocks
    mythrocks committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    f7f1d24 View commit details
    Browse the repository at this point in the history

  2. More appropriate names for tests.

    @mythrocks
    mythrocks committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    b0232b3 View commit details
    Browse the repository at this point in the history

  3. Removed using directives for cudf, cudf::test.

    @mythrocks
    mythrocks committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    f500c45 View commit details
    Browse the repository at this point in the history