Handle empty child columns in row_bit_count() #8791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`row_bit_count()` handles string and list inputs by computing the sizes of the offsets, and that of the elements in the underlying child column. For cases where the child column is empty (e.g. where the input string/ list column contains only nulls), row_bit_count() erroneously attempts to read the contents of the empty `offsets` and `child.data()`, leading to bad reads and crashes. This commit allows `row_bit_count()` to identify empty child row spans as having `0` size. It also correctly handles empty child columns.
mythrocks
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8791 +/- ##
================================================
- Coverage 10.50% 10.15% -0.35%
================================================
Files 116 116
Lines 18573 19623 +1050
================================================
+ Hits 1951 1993 +42
- Misses 16622 17630 +1008
Continue to review full report at Codecov.
|
nvdbaranec
approved these changes
Jul 20, 2021
ttnghia
reviewed
Jul 20, 2021
ttnghia
requested changes
Jul 20, 2021
ttnghia
approved these changes
Jul 20, 2021
|
rerun tests |
|
@gpucibot merge |
|
Thanks for the reviews, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8775.
Addresses failures seen in NVIDIA/spark-rapids/issues/2723.
row_bit_count()handles string and list inputs by computing the sizes of the offsets, and that of the elements in the underlying child column.For cases where the child column is empty (e.g. where the input string/list column contains only nulls), row_bit_count() erroneously attempts to read the contents of the empty
offsetsandchild.data(), leading to bad reads and crashes.This commit allows
row_bit_count()to identify empty child row spans as having0size. It also correctly handles empty child columns.