[REVIEW] Fix replace to handle null values correctly
#8744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
3 - Ready for Review
galipremsagar
changed the title
replace to handle null values correctlyreplace to handle null values correctly
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8744 +/- ##
===============================================
Coverage ? 10.51%
===============================================
Files ? 116
Lines ? 18957
Branches ? 0
===============================================
Hits ? 1993
Misses ? 16964
Partials ? 0 Continue to review full report at Codecov.
|
isVoid
approved these changes
Jul 19, 2021
galipremsagar
added
5 - Ready to Merge
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7293
This PR introduces fixes to
replaceand it's internal APIs which error/fault when there is aNone/<NA>value on eitherlhsorrhsand certain combinations of each. Introduced tests where there were failures previously that are covered by new changes in this PR.