Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] replace fails with RuntimeError when to_replace is None. #7293

Closed
galipremsagar opened this issue Feb 3, 2021 · 6 comments · Fixed by #8744
Closed

[BUG] replace fails with RuntimeError when to_replace is None. #7293

galipremsagar opened this issue Feb 3, 2021 · 6 comments · Fixed by #8744
Assignees
@galipremsagar
Labels
bug Something isn't working Python Affects Python cuDF API.

Comments

@galipremsagar
Copy link
Contributor

Describe the bug
Using replace API we can currently replace any value of a column with <NA> but not vice-versa.

Steps/Code to reproduce bug

>>> s = cudf.Series(['a', 'b', 'c', None])
>>> s
0       a
1       b
2       c
3    <NA>
dtype: object
>>> s.replace('a', None)
0    <NA>
1       b
2       c
3    <NA>
dtype: object
>>> s.replace(None, 'a')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/nvme/0/pgali/envs/cudfdev/lib/python3.7/site-packages/cudf/core/series.py", line 2543, in replace
    result = super().replace(to_replace=to_replace, replacement=value)
  File "/nvme/0/pgali/envs/cudfdev/lib/python3.7/site-packages/cudf/core/frame.py", line 2331, in replace
    all_na_per_column[name],
  File "/nvme/0/pgali/envs/cudfdev/lib/python3.7/site-packages/cudf/core/column/string.py", line 5043, in find_and_replace
    return libcudf.replace.replace(self, to_replace_col, replacement_col)
  File "cudf/_lib/replace.pyx", line 46, in cudf._lib.replace.replace
RuntimeError: cuDF failure at: /nvme/0/pgali/cudf/cpp/src/replace/replace.cu:499: values_to_replace must not have nulls
>>> s.to_pandas().replace([None], ['a'])
0    a
1    b
2    c
3    a
dtype: object

Expected behavior

>>> s.replace([None], ['a'])
0    a
1    b
2    c
3    a
dtype: object

Ideally I'd expect libcudf to replace None with 'a', but is this because of a design limitation or would it be possible to relax this requirement from libcudf side and only error when there are multiple None values in values_to_replace?

or

we could do a fillna at python level when the null_count is 1. and throw when null_count >1. But this would be a two-pass solution as we'd be doing fillna + replace.

Environment overview (please complete the following information)

  • Environment location: [Bare-metal]
  • Method of cuDF install: [from source]

Environment details
Please run and paste the output of the cudf/print_env.sh script here, to gather any other relevant environment details

Click here to see environment details
 **git***
 commit 57d9e48deaa64aa093f58a64218757819f213877 (HEAD -> 6963, origin/6963)
 Author: galipremsagar <[email protected]>
 Date:   Wed Feb 3 10:34:07 2021 -0800
 
 bump down inserting None values
 **git submodules***
 
 ***OS Information***
 DISTRIB_ID=Ubuntu
 DISTRIB_RELEASE=18.04
 DISTRIB_CODENAME=bionic
 DISTRIB_DESCRIPTION="Ubuntu 18.04.4 LTS"
 NAME="Ubuntu"
 VERSION="18.04.4 LTS (Bionic Beaver)"
 ID=ubuntu
 ID_LIKE=debian
 PRETTY_NAME="Ubuntu 18.04.4 LTS"
 VERSION_ID="18.04"
 HOME_URL="https://www.ubuntu.com/"
 SUPPORT_URL="https://help.ubuntu.com/"
 BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
 PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
 VERSION_CODENAME=bionic
 UBUNTU_CODENAME=bionic
 Linux dt07 4.15.0-76-generic #86-Ubuntu SMP Fri Jan 17 17:24:28 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
 
 ***GPU Information***
 Wed Feb  3 11:15:08 2021
 +-----------------------------------------------------------------------------+
 | NVIDIA-SMI 440.64.00    Driver Version: 440.64.00    CUDA Version: 10.2     |
 |-------------------------------+----------------------+----------------------+
 | GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
 | Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
 |===============================+======================+======================|
 |   0  Tesla T4            On   | 00000000:3B:00.0 Off |                    0 |
 | N/A   50C    P0    28W /  70W |    660MiB / 15109MiB |      0%      Default |
 +-------------------------------+----------------------+----------------------+
 |   1  Tesla T4            On   | 00000000:5E:00.0 Off |                    0 |
 | N/A   37C    P8    11W /  70W |     11MiB / 15109MiB |      0%      Default |
 +-------------------------------+----------------------+----------------------+
 |   2  Tesla T4            On   | 00000000:AF:00.0 Off |                    0 |
 | N/A   32C    P8    11W /  70W |     11MiB / 15109MiB |      0%      Default |
 +-------------------------------+----------------------+----------------------+
 |   3  Tesla T4            On   | 00000000:D8:00.0 Off |                    0 |
 | N/A   32C    P8     9W /  70W |     11MiB / 15109MiB |      0%      Default |
 +-------------------------------+----------------------+----------------------+
 
 +-----------------------------------------------------------------------------+
 | Processes:                                                       GPU Memory |
 |  GPU       PID   Type   Process name                             Usage      |
 |=============================================================================|
 |    0     14745      C   /nvme/0/pgali/envs/cudfdev/bin/python        649MiB |
 +-----------------------------------------------------------------------------+
 
 ***CPU***
 Architecture:        x86_64
 CPU op-mode(s):      32-bit, 64-bit
 Byte Order:          Little Endian
 CPU(s):              64
 On-line CPU(s) list: 0-63
 Thread(s) per core:  2
 Core(s) per socket:  16
 Socket(s):           2
 NUMA node(s):        2
 Vendor ID:           GenuineIntel
 CPU family:          6
 Model:               85
 Model name:          Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz
 Stepping:            4
 CPU MHz:             2785.322
 BogoMIPS:            4200.00
 Virtualization:      VT-x
 L1d cache:           32K
 L1i cache:           32K
 L2 cache:            1024K
 L3 cache:            22528K
 NUMA node0 CPU(s):   0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62
 NUMA node1 CPU(s):   1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63
 Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts pku ospke md_clear flush_l1d
 
 ***CMake***
 /nvme/0/pgali/envs/cudfdev/bin/cmake
 cmake version 3.18.5
 
 CMake suite maintained and supported by Kitware (kitware.com/cmake).
 
 ***g++***
 /usr/bin/g++
 g++ (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
 Copyright (C) 2017 Free Software Foundation, Inc.
 This is free software; see the source for copying conditions.  There is NO
 warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 
 
 ***nvcc***
 /usr/local/cuda/bin/nvcc
 nvcc: NVIDIA (R) Cuda compiler driver
 Copyright (c) 2005-2019 NVIDIA Corporation
 Built on Wed_Oct_23_19:24:38_PDT_2019
 Cuda compilation tools, release 10.2, V10.2.89
 
 ***Python***
 /nvme/0/pgali/envs/cudfdev/bin/python
 Python 3.7.9
 
 ***Environment Variables***
 PATH                            : /nvme/0/pgali/envs/cudfdev/bin:/usr/share/swift/usr/bin:/home/nfs/pgali/bin:/home/nfs/pgali/.local/bin:/home/nfs/pgali/anaconda3/condabin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/usr/lib/jvm/default-java/bin:/usr/share/sbt-launcher-packaging/bin/sbt-launch.jar/bin:/usr/lib/spark/bin:/usr/lib/spark/sbin:/usr/local/cuda/bin:/nvme/0/pgali/envs/cudfdev/bin
 LD_LIBRARY_PATH                 : /usr/local/cuda/lib64::/usr/local/cuda/lib64:/usr/local/cuda/extras/CUPTI/lib64
 NUMBAPRO_NVVM                   :
 NUMBAPRO_LIBDEVICE              :
 CONDA_PREFIX                    : /nvme/0/pgali/envs/cudfdev
 PYTHON_PATH                     :
 
 ***conda packages***
 /home/nfs/pgali/anaconda3/condabin/conda
 # packages in environment at /nvme/0/pgali/envs/cudfdev:
 #
 # Name                    Version                   Build  Channel
 _libgcc_mutex             0.1                 conda_forge    conda-forge
 _openmp_mutex             4.5                       1_gnu    conda-forge
 abseil-cpp                20200923.3           h9c3ff4c_0    conda-forge
 alabaster                 0.7.12                     py_0    conda-forge
 apipkg                    1.5                        py_0    conda-forge
 appdirs                   1.4.4              pyh9f0ad1d_0    conda-forge
 argon2-cffi               20.1.0           py37h5e8e339_2    conda-forge
 arrow-cpp                 1.0.1           py37h10a6eae_26_cuda    conda-forge
 arrow-cpp-proc            3.0.0                      cuda    conda-forge
 async_generator           1.10                       py_0    conda-forge
 attrs                     20.3.0             pyhd3deb0d_0    conda-forge
 aws-c-cal                 0.4.5                h54aeb68_4    conda-forge
 aws-c-common              0.4.65               h7f98852_0    conda-forge
 aws-c-event-stream        0.2.6                hbb68377_1    conda-forge
 aws-c-io                  0.8.0                h650c6ac_0    conda-forge
 aws-checksums             0.1.10               h650c6ac_2    conda-forge
 aws-sdk-cpp               1.8.127              hf85971d_0    conda-forge
 babel                     2.9.0              pyhd3deb0d_0    conda-forge
 backcall                  0.2.0              pyh9f0ad1d_0    conda-forge
 backports                 1.0                        py_2    conda-forge
 backports.functools_lru_cache 1.6.1                      py_0    conda-forge
 black                     19.10b0                    py_4    conda-forge
 bleach                    3.2.3              pyh44b312d_0    conda-forge
 bokeh                     2.2.3            py37h89c1867_0    conda-forge
 boost-cpp                 1.74.0               hc6e9bd1_2    conda-forge
 brotli                    1.0.9                h9c3ff4c_4    conda-forge
 brotlipy                  0.7.0           py37h5e8e339_1001    conda-forge
 bzip2                     1.0.8                h7f98852_4    conda-forge
 c-ares                    1.17.1               h36c2ea0_0    conda-forge
 ca-certificates           2020.12.5            ha878542_0    conda-forge
 certifi                   2020.12.5        py37h89c1867_1    conda-forge
 cffi                      1.14.4           py37hc58025e_1    conda-forge
 cfgv                      3.2.0                      py_0    conda-forge
 chardet                   4.0.0            py37h89c1867_1    conda-forge
 clang                     8.0.1                hc9558a2_2    conda-forge
 clang-tools               8.0.1                hc9558a2_2    conda-forge
 clangxx                   8.0.1                         2    conda-forge
 click                     7.1.2              pyh9f0ad1d_0    conda-forge
 cloudpickle               1.6.0                      py_0    conda-forge
 cmake                     3.18.5               h1f3970d_0    rapidsai-nightly
 cmake_setuptools          0.1.3                      py_0    rapidsai
 colorama                  0.4.4              pyh9f0ad1d_0    conda-forge
 commonmark                0.9.1                      py_0    conda-forge
 cryptography              3.3.1            py37h7f0c10b_1    conda-forge
 cudatoolkit               10.2.89              h6bb024c_0    nvidia
 cudf                      0.18.0a0+238.g1715ee7b41          pypi_0    pypi
 cudnn                     7.6.5.32             h01f27c4_1    conda-forge
 cupy                      8.3.0            py37h3e89ef8_1    conda-forge
 cython                    0.29.21          py37hcd2ae1e_2    conda-forge
 cytoolz                   0.11.0           py37h5e8e339_3    conda-forge
 dask                      2021.1.1+5.g5694253b          pypi_0    pypi
 dask-cudf                 branch-0.18-latest-15.gb5ef0fd596.dirty          pypi_0    pypi
 decorator                 4.4.2                      py_0    conda-forge
 defusedxml                0.6.0                      py_0    conda-forge
 distlib                   0.3.1              pyh9f0ad1d_0    conda-forge
 distributed               2021.1.1+5.gb5c36b58          pypi_0    pypi
 dlpack                    0.3                  he1b5a44_1    conda-forge
 docutils                  0.16             py37h89c1867_3    conda-forge
 double-conversion         3.1.5                he1b5a44_2    conda-forge
 editdistance              0.5.3            py37hcd2ae1e_3    conda-forge
 entrypoints               0.3             pyhd8ed1ab_1003    conda-forge
 execnet                   1.7.1                      py_0    conda-forge
 expat                     2.2.9                h9c3ff4c_3    conda-forge
 fastavro                  1.3.0            py37h5e8e339_0    conda-forge
 fastrlock                 0.5              py37hcd2ae1e_2    conda-forge
 filelock                  3.0.12             pyh9f0ad1d_0    conda-forge
 flake8                    3.8.3                      py_1    conda-forge
 flatbuffers               1.12.0               h58526e2_0    conda-forge
 freetype                  2.10.4               h0708190_1    conda-forge
 fsspec                    0.8.5              pyhd8ed1ab_0    conda-forge
 future                    0.18.2           py37h89c1867_3    conda-forge
 gflags                    2.2.2             he1b5a44_1004    conda-forge
 glog                      0.4.0                h49b9bf7_3    conda-forge
 gmp                       6.2.1                h58526e2_0    conda-forge
 grpc-cpp                  1.35.0               h146f9af_0    conda-forge
 heapdict                  1.0.1                      py_0    conda-forge
 hypothesis                6.0.3              pyhd8ed1ab_0    conda-forge
 icu                       68.1                 h58526e2_0    conda-forge
 identify                  1.5.13             pyh44b312d_0    conda-forge
 idna                      2.10               pyh9f0ad1d_0    conda-forge
 imagesize                 1.2.0                      py_0    conda-forge
 importlib-metadata        3.4.0            py37h89c1867_0    conda-forge
 importlib_metadata        3.4.0                hd8ed1ab_0    conda-forge
 iniconfig                 1.1.1              pyh9f0ad1d_0    conda-forge
 ipykernel                 5.4.2            py37h888b3d9_0    conda-forge
 ipython                   7.19.0           py37h888b3d9_2    conda-forge
 ipython_genutils          0.2.0                      py_1    conda-forge
 isort                     5.0.7            py37hc8dfbb8_0    conda-forge
 jedi                      0.17.2           py37h89c1867_1    conda-forge
 jinja2                    2.11.2             pyh9f0ad1d_0    conda-forge
 jpeg                      9d                   h36c2ea0_0    conda-forge
 jsonschema                3.2.0                      py_2    conda-forge
 jupyter_client            6.1.11             pyhd8ed1ab_1    conda-forge
 jupyter_core              4.7.0            py37h89c1867_1    conda-forge
 jupyterlab_pygments       0.1.2              pyh9f0ad1d_0    conda-forge
 krb5                      1.17.2               h926e7f8_0    conda-forge
 lcms2                     2.11                 hcbb858e_1    conda-forge
 ld_impl_linux-64          2.35.1               hea4e1c9_1    conda-forge
 libblas                   3.9.0                7_openblas    conda-forge
 libcblas                  3.9.0                7_openblas    conda-forge
 libcurl                   7.71.1               hcdd3856_8    conda-forge
 libedit                   3.1.20191231         he28a2e2_2    conda-forge
 libev                     4.33                 h516909a_1    conda-forge
 libevent                  2.1.10               hcdb4288_3    conda-forge
 libffi                    3.3                  h58526e2_2    conda-forge
 libgcc-ng                 9.3.0               h2828fa1_18    conda-forge
 libgfortran-ng            9.3.0               hff62375_18    conda-forge
 libgfortran5              9.3.0               hff62375_18    conda-forge
 libgomp                   9.3.0               h2828fa1_18    conda-forge
 liblapack                 3.9.0                7_openblas    conda-forge
 libllvm10                 10.0.1               he513fc3_3    conda-forge
 libllvm8                  8.0.1                hc9558a2_0    conda-forge
 libnghttp2                1.41.0               h8cfc5f6_2    conda-forge
 libopenblas               0.3.12          pthreads_h4812303_1    conda-forge
 libpng                    1.6.37               h21135ba_2    conda-forge
 libprotobuf               3.14.0               h780b84a_0    conda-forge
 librmm                    0.18.0a210127   cuda10.2_ge899c68_25    rapidsai-nightly
 libsodium                 1.0.18               h36c2ea0_1    conda-forge
 libssh2                   1.9.0                hab1572f_5    conda-forge
 libstdcxx-ng              9.3.0               h6de172a_18    conda-forge
 libthrift                 0.13.0               h5aa387f_6    conda-forge
 libtiff                   4.2.0                hdc55705_0    conda-forge
 libutf8proc               2.6.1                h7f98852_0    conda-forge
 libuv                     1.40.0               h7f98852_0    conda-forge
 libwebp-base              1.1.0                h36c2ea0_3    conda-forge
 llvmlite                  0.35.0           py37h9d7f4d0_1    conda-forge
 locket                    0.2.0                      py_2    conda-forge
 lz4-c                     1.9.3                h9c3ff4c_0    conda-forge
 markdown                  3.3.3              pyh9f0ad1d_0    conda-forge
 markupsafe                1.1.1            py37h5e8e339_3    conda-forge
 mccabe                    0.6.1                      py_1    conda-forge
 mimesis                   4.0.0              pyh9f0ad1d_0    conda-forge
 mistune                   0.8.4           py37h5e8e339_1003    conda-forge
 more-itertools            8.6.0              pyhd8ed1ab_0    conda-forge
 msgpack-python            1.0.2            py37h2527ec5_1    conda-forge
 mypy                      0.782                      py_0    conda-forge
 mypy_extensions           0.4.3            py37h89c1867_3    conda-forge
 nbclient                  0.5.1                      py_0    conda-forge
 nbconvert                 6.0.7            py37h89c1867_3    conda-forge
 nbformat                  5.1.2              pyhd8ed1ab_1    conda-forge
 nbsphinx                  0.8.1              pyh44b312d_0    conda-forge
 nccl                      2.8.3.1              h1a5f58c_0    conda-forge
 ncurses                   6.2                  h58526e2_4    conda-forge
 nest-asyncio              1.4.3              pyhd8ed1ab_0    conda-forge
 nodeenv                   1.5.0              pyh9f0ad1d_0    conda-forge
 notebook                  6.2.0            py37h89c1867_0    conda-forge
 numba                     0.52.0           py37hdc94413_0    conda-forge
 numpy                     1.19.5           py37haa41c4c_1    conda-forge
 numpydoc                  1.1.0                      py_1    conda-forge
 nvtx                      0.2.1            py37h5e8e339_2    conda-forge
 olefile                   0.46               pyh9f0ad1d_1    conda-forge
 openssl                   1.1.1i               h7f98852_0    conda-forge
 orc                       1.6.7                h7950760_0    conda-forge
 packaging                 20.8               pyhd3deb0d_0    conda-forge
 pandas                    1.1.5            py37hdc94413_0    conda-forge
 pandoc                    1.19.2                        0    conda-forge
 pandocfilters             1.4.2                      py_1    conda-forge
 parquet-cpp               1.5.1                         2    conda-forge
 parso                     0.7.1              pyh9f0ad1d_0    conda-forge
 partd                     1.1.0                      py_0    conda-forge
 pathspec                  0.8.1              pyhd3deb0d_0    conda-forge
 pexpect                   4.8.0              pyh9f0ad1d_2    conda-forge
 pickleshare               0.7.5                   py_1003    conda-forge
 pillow                    8.1.0            py37he6b4880_1    conda-forge
 pip                       21.0               pyhd8ed1ab_0    conda-forge
 pluggy                    0.13.1           py37h89c1867_4    conda-forge
 pre-commit                2.9.3            py37h89c1867_0    conda-forge
 pre_commit                2.9.3                hd8ed1ab_0    conda-forge
 prometheus_client         0.9.0              pyhd3deb0d_0    conda-forge
 prompt-toolkit            3.0.14             pyha770c72_0    conda-forge
 protobuf                  3.14.0           py37hcd2ae1e_1    conda-forge
 psutil                    5.8.0            py37h5e8e339_1    conda-forge
 ptyprocess                0.7.0              pyhd3deb0d_0    conda-forge
 py                        1.10.0             pyhd3deb0d_0    conda-forge
 py-cpuinfo                7.0.0              pyh9f0ad1d_0    conda-forge
 pyarrow                   1.0.1           py37h9267296_26_cuda    conda-forge
 pycodestyle               2.6.0              pyh9f0ad1d_0    conda-forge
 pycparser                 2.20               pyh9f0ad1d_2    conda-forge
 pyflakes                  2.2.0              pyh9f0ad1d_0    conda-forge
 pygments                  2.7.4              pyhd8ed1ab_0    conda-forge
 pyopenssl                 20.0.1             pyhd8ed1ab_0    conda-forge
 pyorc                     0.4.0                    pypi_0    pypi
 pyparsing                 2.4.7              pyh9f0ad1d_0    conda-forge
 pyrsistent                0.17.3           py37h5e8e339_2    conda-forge
 pysocks                   1.7.1            py37h89c1867_3    conda-forge
 pytest                    6.2.2            py37h89c1867_0    conda-forge
 pytest-benchmark          3.2.3              pyh9f0ad1d_0    conda-forge
 pytest-forked             1.2.0              pyh9f0ad1d_0    conda-forge
 pytest-xdist              2.2.0              pyhd8ed1ab_0    conda-forge
 python                    3.7.9           hffdb5ce_0_cpython    conda-forge
 python-dateutil           2.8.1                      py_0    conda-forge
 python_abi                3.7                     1_cp37m    conda-forge
 pytz                      2020.5             pyhd8ed1ab_0    conda-forge
 pyyaml                    5.4.1            py37h5e8e339_0    conda-forge
 pyzmq                     21.0.1           py37h499b945_0    conda-forge
 rapidjson                 1.1.0             he1b5a44_1002    conda-forge
 re2                       2020.11.01           h58526e2_0    conda-forge
 readline                  8.0                  he28a2e2_2    conda-forge
 recommonmark              0.7.1              pyhd8ed1ab_0    conda-forge
 regex                     2020.11.13       py37h5e8e339_1    conda-forge
 requests                  2.25.1             pyhd3deb0d_0    conda-forge
 rhash                     1.4.1                h7f98852_0    conda-forge
 rmm                       0.18.0a210127   cuda_10.2_py37_ge899c68_25    rapidsai-nightly
 s2n                       0.10.24              h9b69904_0    conda-forge
 send2trash                1.5.0                      py_0    conda-forge
 setuptools                49.6.0           py37h89c1867_3    conda-forge
 six                       1.15.0             pyh9f0ad1d_0    conda-forge
 snappy                    1.1.8                he1b5a44_3    conda-forge
 snowballstemmer           2.1.0              pyhd8ed1ab_0    conda-forge
 sortedcontainers          2.3.0              pyhd8ed1ab_0    conda-forge
 spdlog                    1.7.0                hc9558a2_2    conda-forge
 sphinx                    3.4.3              pyhd8ed1ab_0    conda-forge
 sphinx-copybutton         0.3.1              pyhd8ed1ab_0    conda-forge
 sphinx-markdown-tables    0.0.15             pyhd3deb0d_0    conda-forge
 sphinx_rtd_theme          0.5.1              pyhd3deb0d_0    conda-forge
 sphinxcontrib-applehelp   1.0.2                      py_0    conda-forge
 sphinxcontrib-devhelp     1.0.2                      py_0    conda-forge
 sphinxcontrib-htmlhelp    1.0.3                      py_0    conda-forge
 sphinxcontrib-jsmath      1.0.1                      py_0    conda-forge
 sphinxcontrib-qthelp      1.0.3                      py_0    conda-forge
 sphinxcontrib-serializinghtml 1.1.4                      py_0    conda-forge
 sphinxcontrib-websupport  1.2.4              pyh9f0ad1d_0    conda-forge
 sqlite                    3.34.0               h74cdb3f_0    conda-forge
 streamz                   0.6.2              pyh44b312d_0    conda-forge
 tblib                     1.6.0                      py_0    conda-forge
 terminado                 0.9.2            py37h89c1867_0    conda-forge
 testpath                  0.4.4                      py_0    conda-forge
 tk                        8.6.10               h21135ba_1    conda-forge
 toml                      0.10.2             pyhd8ed1ab_0    conda-forge
 toolz                     0.11.1                     py_0    conda-forge
 tornado                   6.1              py37h5e8e339_1    conda-forge
 traitlets                 5.0.5                      py_0    conda-forge
 typed-ast                 1.4.2            py37h5e8e339_0    conda-forge
 typing_extensions         3.7.4.3                    py_0    conda-forge
 urllib3                   1.26.3             pyhd8ed1ab_0    conda-forge
 virtualenv                20.4.0           py37h89c1867_0    conda-forge
 wcwidth                   0.2.5              pyh9f0ad1d_2    conda-forge
 webencodings              0.5.1                      py_1    conda-forge
 wheel                     0.36.2             pyhd3deb0d_0    conda-forge
 xz                        5.2.5                h516909a_1    conda-forge
 yaml                      0.2.5                h516909a_0    conda-forge
 zeromq                    4.3.3                h58526e2_3    conda-forge
 zict                      2.0.0                      py_0    conda-forge
 zipp                      3.4.0                      py_0    conda-forge
 zlib                      1.2.11            h516909a_1010    conda-forge
 zstd                      1.4.8                ha95c52a_1    conda-forge

Additional context
Add any other context about the problem here.
@galipremsagar galipremsagar added bug Something isn't working Needs Triage Need team to review and classify libcudf Affects libcudf (C++/CUDA) code. labels Feb 3, 2021
@galipremsagar galipremsagar mentioned this issue Feb 3, 2021
Merged
@davidwendt
Copy link
Contributor

libcudf has a replace_nulls API if that helps
https://docs.rapids.ai/api/libcudf/stable/group__transformation__replace.html#gad359a898c2b11e70c3e33720259c5596

@kkraus14 kkraus14 removed the Needs Triage Need team to review and classify label Feb 16, 2021
@kkraus14
Copy link
Collaborator

@davidwendt I think the desire is to replace a value with a null, not replacing a null with a value.

@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@kkraus14 kkraus14 added 0 - Backlog In queue waiting for assignment and removed inactive-30d labels Mar 18, 2021
@davidwendt
Copy link
Contributor

From the description it looks like replacing a value with a null already works.
To replace a null with a value, you can use libcudf's replace_nulls

>>> libcudf.replace.replace_nulls(s._column, 'a')
<cudf.core.column.string.StringColumn object at 0x7fbf8066e710>
[
  "a",
  "b",
  "c",
  "a"
]
dtype: object

@galipremsagar galipremsagar added Python Affects Python cuDF API. and removed 0 - Backlog In queue waiting for assignment libcudf Affects libcudf (C++/CUDA) code. labels Apr 15, 2021
@galipremsagar
Copy link
Contributor Author

galipremsagar commented Apr 15, 2021 •
edited
Loading

From the description it looks like replacing a value with a null already works.
To replace a null with a value, you can use libcudf's replace_nulls

>>> libcudf.replace.replace_nulls(s._column, 'a')
<cudf.core.column.string.StringColumn object at 0x7fbf8066e710>
[
  "a",
  "b",
  "c",
  "a"
]
dtype: object

Thanks @davidwendt , this is what is needed for scalar replace. Apologies for the confusion created by me.

Update for column-like replace: Connected offline and decided we'll do a two-pass approach if we have nulls in to_replace: i.e., replace + replace_nulls

@galipremsagar galipremsagar self-assigned this Apr 15, 2021
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@galipremsagar galipremsagar mentioned this issue Jul 14, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue Jul 20, 2021
@galipremsagar
Fix replace to handle null values correctly (#8744)
0e59d05 
Fixes: #7293 

This PR introduces fixes to `replace` and it's internal APIs which error/fault when there is a `None`/`<NA>` value on either `lhs` or `rhs` and certain combinations of each. Introduced tests where there were failures previously that are covered by new changes in this PR.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Michael Wang (https://github.com/isVoid)

URL: #8744
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galipremsagar galipremsagar

Labels
bug Something isn't working Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[REVIEW] Fix replace to handle null values correctly galipremsagar/cudf
3 participants
@kkraus14 @galipremsagar @davidwendt