Update cmake to 3.20.5 in the Java Docker image [skip ci] #8593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NvTimLiu
added
4 - Needs cuDF (Java) Reviewer
3 - Ready for Review
NvTimLiu
commented
Jun 23, 2021
| @@ -48,9 +48,6 @@ export GIT_COMMITTER_EMAIL="[email protected]" | |||
| export CUDACXX=/usr/local/cuda/bin/nvcc | |||
| export LIBCUDF_KERNEL_CACHE_PATH=/rapids | |||
|
|
|||
| # add cmake 3.19 to PATH | |||
| export PATH=/usr/local/cmake-3.19.0-Linux-x86_64/bin:$PATH | |||
There was a problem hiding this comment.
Move this line into the Dockerfile, where the corresponding version of cmake tar ball is downloaded
|
Fix issue #8592 |
jlowe
approved these changes
Jun 23, 2021
jlowe
changed the title
NvTimLiu
added
the
5 - Ready to Merge
|
@gpucibot merge |
cuDF updated the cmake requiring 3.20.1 or higher version with rapidsai#8586, while cmake version in the java docker image is still 3.19.0. Need to update cmake version in the java docker image to meet the requirement. Signed-off-by: Tim Liu <[email protected]>
vyasr
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cuDF updated the cmake requiring
3.20.1or higher version with #8586, while cmake version in the java docker image is still3.19.0.Need to update cmake version in the java docker image to meet the requirement.
Signed-off-by: Tim Liu [email protected]