Use cmake 3.20.1 as it is now required by rmm #8586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
3 - Ready for Review
dillon-cullinan
approved these changes
Jun 22, 2021
galipremsagar
added
5 - Ready to Merge
|
@gpucibot merge |
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8586 +/- ##
===============================================
Coverage ? 82.99%
===============================================
Files ? 109
Lines ? 18212
Branches ? 0
===============================================
Hits ? 15115
Misses ? 3097
Partials ? 0 Continue to review full report at Codecov.
|
NvTimLiu
added a commit
to NvTimLiu/cudf
that referenced
this pull request
Jun 24, 2021
cuDF updated the cmake requiring 3.20.1 or higher version with rapidsai#8586, while cmake version in the java docker image is still 3.19.0. Need to update cmake version in the java docker image to meet the requirement. Signed-off-by: Tim Liu <[email protected]>
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 24, 2021
cuDF updated the cmake requiring `3.20.1` or higher version with #8586, while cmake version in the java docker image is still `3.19.0`. Need to update cmake version in the java docker image to meet the requirement. Signed-off-by: Tim Liu <[email protected]> Authors: - https://github.com/NvTimLiu Approvers: - Jason Lowe (https://github.com/jlowe) URL: #8593
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects failures when compiling in CI due to the bump in requirements by rmm usage of rapids-cmake