-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] cudf consistently specifies the cuda runtime #7887
[REVIEW] cudf consistently specifies the cuda runtime #7887
Conversation
CMake has two ways to control the CUDA runtime to link too. This makes sure that the CUDA language controls and the CUDAToolkit both target the same runtime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Locally tested with this and libcudf.so didn't have static cuda symbols. Thanks @robertmaynard
@gpucibot merge |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7887 +/- ##
===============================================
+ Coverage 81.86% 82.74% +0.88%
===============================================
Files 101 103 +2
Lines 16884 17701 +817
===============================================
+ Hits 13822 14647 +825
+ Misses 3062 3054 -8
Continue to review full report at Codecov.
|
CMake has two ways to control the CUDA runtime to link too. This makes sure that the CUDA language controls and the CUDAToolkit both target the same runtime
Issue brought up in: #7600