Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] cudf consistently specifies the cuda runtime #7887

Conversation

robertmaynard
Copy link
Contributor

CMake has two ways to control the CUDA runtime to link too. This makes sure that the CUDA language controls and the CUDAToolkit both target the same runtime

Issue brought up in: #7600

CMake has two ways to control the CUDA runtime to link too.
This makes sure that the CUDA language controls and the
CUDAToolkit both target the same runtime
@robertmaynard robertmaynard requested a review from a team as a code owner April 7, 2021 16:50
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Apr 7, 2021
Copy link
Contributor

@abellina abellina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally tested with this and libcudf.so didn't have static cuda symbols. Thanks @robertmaynard

@kkraus14 kkraus14 added bug Something isn't working non-breaking Non-breaking change labels Apr 7, 2021
@kkraus14
Copy link
Collaborator

kkraus14 commented Apr 7, 2021

@gpucibot merge

@kkraus14 kkraus14 added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Apr 7, 2021
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #7887 (3873912) into branch-0.19 (7871e7a) will increase coverage by 0.88%.
The diff coverage is n/a.

❗ Current head 3873912 differs from pull request most recent head d6145cf. Consider uploading reports for the commit d6145cf to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7887      +/-   ##
===============================================
+ Coverage        81.86%   82.74%   +0.88%     
===============================================
  Files              101      103       +2     
  Lines            16884    17701     +817     
===============================================
+ Hits             13822    14647     +825     
+ Misses            3062     3054       -8     
Impacted Files Coverage Δ
python/cudf/cudf/utils/dtypes.py 83.44% <0.00%> (-6.08%) ⬇️
python/cudf/cudf/core/column/lists.py 87.41% <0.00%> (-3.99%) ⬇️
python/cudf/cudf/core/column/decimal.py 92.92% <0.00%> (-1.95%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 92.41% <0.00%> (-1.04%) ⬇️
python/cudf/cudf/utils/utils.py 85.36% <0.00%> (-0.07%) ⬇️
python/dask_cudf/dask_cudf/backends.py 89.58% <0.00%> (-0.05%) ⬇️
python/cudf/cudf/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 78.71% <0.00%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f84ea8...d6145cf. Read the comment docs.

@rapids-bot rapids-bot bot merged commit a06d2dc into rapidsai:branch-0.19 Apr 7, 2021
@robertmaynard robertmaynard deleted the fix/consistently_use_same_cuda_runtime branch April 7, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants