Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Enable join on decimal columns #7764

Merged
merged 9 commits into from
Apr 2, 2021
Merged

[REVIEW] Enable join on decimal columns #7764

merged 9 commits into from
Apr 2, 2021

Conversation

ChrisJar
Copy link
Contributor

@ChrisJar ChrisJar commented Mar 30, 2021 •
edited by kkraus14
Loading

This enables joins on decimal columns with the same precision and scale.

Closes #7497
Depends on #7788

@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 30, 2021
@codecov
Copy link

codecov bot commented Mar 31, 2021 •
edited
Loading

Codecov Report

Merging #7764 (1ea15a7) into branch-0.19 (7871e7a) will increase coverage by 0.80%.
The diff coverage is n/a.

❗ Current head 1ea15a7 differs from pull request most recent head bbd4bd2. Consider uploading reports for the commit bbd4bd2 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7764      +/-   ##
===============================================
+ Coverage        81.86%   82.66%   +0.80%     
===============================================
  Files              101      103       +2     
  Lines            16884    17589     +705     
===============================================
+ Hits             13822    14540     +718     
+ Misses            3062     3049      -13
Impacted Files Coverage Δ
python/cudf/cudf/utils/dtypes.py 83.44% <0.00%> (-6.08%) ⬇️
python/cudf/cudf/core/column/lists.py 87.32% <0.00%> (-4.08%) ⬇️
python/dask_cudf/dask_cudf/backends.py 87.50% <0.00%> (-2.13%) ⬇️
python/cudf/cudf/core/column/decimal.py 92.92% <0.00%> (-1.95%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 92.41% <0.00%> (-1.04%) ⬇️
python/cudf/cudf/core/column/column.py 87.63% <0.00%> (-0.13%) ⬇️
python/cudf/cudf/utils/utils.py 85.36% <0.00%> (-0.07%) ⬇️
python/cudf/cudf/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 78.71% <0.00%> (ø)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f30fcd...bbd4bd2. Read the comment docs.

@ChrisJar ChrisJar changed the title [WIP] Enable join on decimal columns [REVIEW] Enable join on decimal columns Mar 31, 2021
@ChrisJar ChrisJar marked this pull request as ready for review March 31, 2021 16:12
@ChrisJar ChrisJar requested a review from a team as a code owner March 31, 2021 16:12
@kkraus14 kkraus14 added the 3 - Ready for Review Ready for review by team label Mar 31, 2021
@kkraus14 kkraus14 added feature request New feature or request non-breaking Non-breaking change 5 - Merge After Dependencies labels Mar 31, 2021
shwina
shwina approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

vyasr
vyasr approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, one minor comment that we can punt on if time's pressing.

python/cudf/cudf/tests/test_joining.py Outdated Show resolved Hide resolved
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Apr 1, 2021
@kkraus14
Copy link
Collaborator

kkraus14 commented Apr 1, 2021

@gpucibot merge

1 similar comment
@kkraus14
Copy link
Collaborator

kkraus14 commented Apr 2, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit dee9238 into rapidsai:branch-0.19 Apr 2, 2021
shwina pushed a commit to shwina/cudf that referenced this pull request Apr 7, 2021
@ChrisJar @shwina
Enable join on decimal columns (rapidsai#7764)
9fa8679 
This enables joins on decimal columns with the same precision and scale.

Closes rapidsai#7497 
Depends on rapidsai#7788

Authors:
  - https://github.com/ChrisJar

Approvers:
  - Keith Kraus (https://github.com/kkraus14)
  - Ashwin Srinath (https://github.com/shwina)
  - https://github.com/brandon-b-miller
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: rapidsai#7764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgsl888prabhu rgsl888prabhu rgsl888prabhu left review comments

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

@shwina shwina shwina approved these changes

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Implement merge for dataframes with decimal columns
6 participants
@ChrisJar @kkraus14 @vyasr @shwina @rgsl888prabhu @brandon-b-miller