-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Implement merge for dataframes with decimal columns #7497
Labels
Comments
ChrisJar
added
Needs Triage
Need team to review and classify
feature request
New feature or request
labels
Mar 3, 2021
kkraus14
added
Python
Affects Python cuDF API.
and removed
Needs Triage
Need team to review and classify
labels
Mar 3, 2021
This already works in libcudf, right @codereport ? |
Yes, libcudf supports this. |
rapids-bot bot
pushed a commit
that referenced
this issue
Apr 2, 2021
This enables joins on decimal columns with the same precision and scale. Closes #7497 Depends on #7788 Authors: - https://github.com/ChrisJar Approvers: - Keith Kraus (https://github.com/kkraus14) - Ashwin Srinath (https://github.com/shwina) - https://github.com/brandon-b-miller - Vyas Ramasubramani (https://github.com/vyasr) URL: #7764
shwina
pushed a commit
to shwina/cudf
that referenced
this issue
Apr 7, 2021
This enables joins on decimal columns with the same precision and scale. Closes rapidsai#7497 Depends on rapidsai#7788 Authors: - https://github.com/ChrisJar Approvers: - Keith Kraus (https://github.com/kkraus14) - Ashwin Srinath (https://github.com/shwina) - https://github.com/brandon-b-miller - Vyas Ramasubramani (https://github.com/vyasr) URL: rapidsai#7764
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
I would like to be able to merge dataframes that contain columns with type
decimal
Describe the solution you'd like
I would like to merge
DataFrames
withdecimal
columns the way I can currently mergeDataFrames
withfloat
columns. For example:returns
However, after casting the
float
columns todecimal
columnsIt returns
The text was updated successfully, but these errors were encountered: