Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Implement scan operations for decimal columns #7707

Merged
merged 3 commits into from
Mar 24, 2021

Conversation

ChrisJar
Copy link
Contributor

This adds support for cummin, cummax, and cumsum in cuDF for columns with type decimal

@ChrisJar ChrisJar requested a review from a team as a code owner March 24, 2021 18:37
@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 24, 2021
@kkraus14 kkraus14 added feature request New feature or request non-breaking Non-breaking change labels Mar 24, 2021
@ChrisJar ChrisJar changed the title Implement scan operations for decimal columns [REVIEW] Implement scan operations for decimal columns Mar 24, 2021
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #7707 (2a702c3) into branch-0.19 (7871e7a) will increase coverage by 0.24%.
The diff coverage is n/a.

❗ Current head 2a702c3 differs from pull request most recent head ae77f0c. Consider uploading reports for the commit ae77f0c to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7707      +/-   ##
===============================================
+ Coverage        81.86%   82.10%   +0.24%     
===============================================
  Files              101      101              
  Lines            16884    17084     +200     
===============================================
+ Hits             13822    14027     +205     
+ Misses            3062     3057       -5     
Impacted Files Coverage Δ
python/cudf/cudf/core/buffer.py 83.63% <ø> (+4.39%) ⬆️
python/cudf/cudf/core/column/categorical.py 91.62% <ø> (+0.23%) ⬆️
python/cudf/cudf/core/column/column.py 87.51% <ø> (-0.25%) ⬇️
python/cudf/cudf/core/column/datetime.py 89.09% <ø> (ø)
python/cudf/cudf/core/column/decimal.py 92.95% <ø> (-1.92%) ⬇️
python/cudf/cudf/core/column/lists.py 89.60% <ø> (-1.80%) ⬇️
python/cudf/cudf/core/column/numerical.py 94.83% <ø> (-0.20%) ⬇️
python/cudf/cudf/core/column/string.py 86.58% <ø> (+0.08%) ⬆️
python/cudf/cudf/core/column/timedelta.py 88.23% <ø> (ø)
python/cudf/cudf/core/column_accessor.py 96.00% <ø> (+0.68%) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 267d29b...ae77f0c. Read the comment docs.

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Mar 24, 2021
@kkraus14
Copy link
Collaborator

@gpucibot merge

1 similar comment
@kkraus14
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f38daf3 into rapidsai:branch-0.19 Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants