Skip to content

Commit

Permalink
Move up error
Browse files Browse the repository at this point in the history
  • Loading branch information
Chris Jarrett committed Mar 24, 2021
1 parent 78d7c55 commit ae77f0c
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions python/cudf/cudf/core/series.py
Original file line number Diff line number Diff line change
Expand Up @@ -4775,6 +4775,11 @@ def cumprod(self, axis=0, skipna=True, *args, **kwargs):
if axis not in (None, 0):
raise NotImplementedError("axis parameter is not implemented yet")

if is_decimal_dtype(self.dtype):
raise NotImplementedError(
"cumprod does not currently support decimal types"
)

skipna = True if skipna is None else skipna

if skipna:
Expand All @@ -4787,11 +4792,6 @@ def cumprod(self, axis=0, skipna=True, *args, **kwargs):
)
result_col[first_index:] = None

if is_decimal_dtype(result_col.dtype):
raise NotImplementedError(
"cumprod does not currently support decimal types"
)

# pandas always returns int64 dtype if original dtype is int or `bool`
if np.issubdtype(result_col.dtype, np.integer) or np.issubdtype(
result_col.dtype, np.bool_
Expand Down

0 comments on commit ae77f0c

Please sign in to comment.