Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Update to official libcu++ on Github #6275

Merged
merged 32 commits into from
Dec 8, 2020
Merged

[REVIEW] Update to official libcu++ on Github #6275

merged 32 commits into from
Dec 8, 2020

Conversation

trxcllnt
Copy link
Contributor

@trxcllnt trxcllnt commented Sep 20, 2020 •
edited
Loading

Update to libcu++ on Github.

@trxcllnt trxcllnt requested review from a team as code owners September 20, 2020 01:04
@trxcllnt trxcllnt mentioned this pull request Sep 20, 2020
Closed
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@trxcllnt trxcllnt requested a review from jrhemstad September 20, 2020 01:08
@trxcllnt
Copy link
Contributor Author

rerun tests

cwharris
cwharris requested changes Sep 20, 2020
View reviewed changes
Copy link
Contributor

@cwharris cwharris left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

changes in the pr look good, but it’s not obvious what changes are made in the trxcllnt/libcudacxx clone. let’s get ops to clone libcudacxx, and then open a pr from the trxcllnt clone to the rapidsai clone so we can use the standard review process.

alternatively, we point at nvidia/libcudacxx and merge the type_trait/chrono backports there. thats preferable if libcudacxx team is cool with the changes.

thirdparty/CMakeLists.txt Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 23, 2020 •
edited
Loading

Codecov Report

Merging #6275 (98fb652) into branch-0.18 (f6b16ab) will increase coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #6275      +/-   ##
===============================================
+ Coverage        81.59%   82.03%   +0.43%     
===============================================
  Files               96       96              
  Lines            15927    16282     +355     
===============================================
+ Hits             12996    13357     +361     
+ Misses            2931     2925       -6
Impacted Files Coverage Δ
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/_version.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_csv.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_orc.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_json.py 100.00% <0.00%> (ø)
...ython/dask_cudf/dask_cudf/io/tests/test_parquet.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/applyutils.py 98.74% <0.00%> (+0.02%) ⬆️
python/cudf/cudf/core/join/join.py 92.44% <0.00%> (+0.03%) ⬆️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6b16ab...98fb652. Read the comment docs.

@trxcllnt trxcllnt mentioned this pull request Sep 23, 2020
Merged
@harrism
Copy link
Member

harrism commented Oct 6, 2020

Moving to 0.17

@harrism harrism changed the base branch from branch-0.16 to branch-0.17 October 6, 2020 04:57
@harrism harrism added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. labels Oct 6, 2020
@trxcllnt trxcllnt changed the base branch from branch-0.17 to branch-0.18 December 2, 2020 19:47
@trxcllnt
Copy link
Contributor Author

trxcllnt commented Dec 4, 2020

rerun tests

@trxcllnt trxcllnt added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change tech debt and removed 0 - Blocked Cannot progress due to external reasons labels Dec 4, 2020
@harrism
Copy link
Member

harrism commented Dec 7, 2020

rerun tests

kkraus14
kkraus14 requested changes Dec 7, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
cpp/src/rolling/rolling.cu Outdated Show resolved Hide resolved
cpp/src/binaryop/binaryop.cpp Outdated Show resolved Hide resolved
cpp/src/transform/transform.cpp Outdated Show resolved Hide resolved
harrism
harrism requested changes Dec 8, 2020
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for the #include fixes I suggested.

@harrism
Copy link
Member

harrism commented Dec 8, 2020

Make sure to remove all the strikethrough text from the description before merging.

@trxcllnt @harrism
Fix quoted includes
beaa827 
Co-authored-by: Mark Harris <[email protected]>
@trxcllnt trxcllnt requested a review from harrism December 8, 2020 05:14
@jrhemstad jrhemstad added 6 - Okay to Auto-Merge and removed 3 - Ready for Review Ready for review by team labels Dec 8, 2020
@kkraus14 kkraus14 removed the request for review from a team December 8, 2020 19:45
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge CMake CMake build issue labels Dec 8, 2020
@rapids-bot rapids-bot bot merged commit 78f9789 into rapidsai:branch-0.18 Dec 8, 2020
@jrhemstad jrhemstad mentioned this pull request Dec 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

@cwharris cwharris cwharris approved these changes

@harrism harrism harrism approved these changes

@codereport codereport Awaiting requested review from codereport

@jrhemstad jrhemstad Awaiting requested review from jrhemstad

@galipremsagar galipremsagar Awaiting requested review from galipremsagar

Assignees

@trxcllnt trxcllnt

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@trxcllnt @GPUtester @harrism @jrhemstad @ajschmidt8 @cwharris @kkraus14