Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Upgrade to libcu++ on GitHub #297

Merged
merged 8 commits into from
Dec 9, 2020
Merged

[REVIEW] Upgrade to libcu++ on GitHub #297

merged 8 commits into from
Dec 9, 2020

Conversation

trxcllnt
Copy link
Contributor

@trxcllnt trxcllnt commented Sep 23, 2020 •
edited
Loading

Update to libcu++ on Github.

@trxcllnt trxcllnt added the 2 - In Progress Currenty a work in progress label Sep 23, 2020
@trxcllnt trxcllnt requested review from a team as code owners September 23, 2020 16:53
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@trxcllnt trxcllnt requested a review from a team as a code owner November 20, 2020 18:40
harrism
harrism requested changes Dec 8, 2020
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some header stuff.

cpp/include/cuspatial/cubic_spline.hpp Outdated Show resolved Hide resolved
cpp/src/indexing/construction/detail/utilities.cuh Outdated Show resolved Hide resolved
cpp/src/join/detail/traversal.cuh Outdated Show resolved Hide resolved
cpp/src/spatial/hausdorff.cu Outdated Show resolved Hide resolved
@trxcllnt trxcllnt changed the base branch from branch-0.16 to branch-0.18 December 8, 2020 16:00
@trxcllnt
Copy link
Contributor Author

trxcllnt commented Dec 8, 2020 •
edited
Loading

@harrism looks like the base was set to branch-0.16 for some reason. Changing it invalidated some of your suggestions, but I'll merge the rest.

Edit: went back and fixed all the quoted headers to be relative paths + noticed two public hausdorff headers that should've been in src/.

@trxcllnt trxcllnt added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change tech debt Related to improving software quality labels Dec 8, 2020
@trxcllnt trxcllnt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Dec 8, 2020
@trxcllnt trxcllnt changed the title [WIP] Upgrade to libcu++ on GitHub [REVIEW] Upgrade to libcu++ on GitHub Dec 8, 2020
@trxcllnt
Copy link
Contributor Author

trxcllnt commented Dec 8, 2020

rerun tests

@trxcllnt trxcllnt self-assigned this Dec 8, 2020
@trxcllnt
Copy link
Contributor Author

trxcllnt commented Dec 9, 2020

rerun tests

@trxcllnt trxcllnt mentioned this pull request Dec 9, 2020
Merged
@trxcllnt trxcllnt requested a review from harrism December 9, 2020 01:19
@trxcllnt trxcllnt added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Dec 9, 2020
@harrism harrism removed the 5 - Ready to Merge Testing and reviews complete, ready to merge label Dec 9, 2020
@rapids-bot rapids-bot bot merged commit fa778a4 into rapidsai:branch-0.18 Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwharris cwharris cwharris approved these changes

@harrism harrism harrism approved these changes

Assignees

@trxcllnt trxcllnt

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change tech debt Related to improving software quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trxcllnt @GPUtester @harrism @cwharris