Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove WheelHelpers.cmake #17276

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Nov 7, 2024

Description

Related to rapidsai/build-planning#33 and rapidsai/build-planning#74

The last use of CMake function install_aliased_imported_targets() here was removed in #16946. This proposes removing the file holding its definition.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 7, 2024
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue labels Nov 7, 2024
@jameslamb jameslamb changed the title WIP: remove WheelHelpers.cmake remove WheelHelpers.cmake Nov 8, 2024
@jameslamb jameslamb requested a review from vyasr November 8, 2024 14:27
@jameslamb jameslamb marked this pull request as ready for review November 8, 2024 14:27
@jameslamb jameslamb requested a review from a team as a code owner November 8, 2024 14:27
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit c46cf76 into rapidsai:branch-24.12 Nov 8, 2024
113 checks passed
@jameslamb jameslamb deleted the remove-script branch November 8, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants