-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use nvcomp wheel instead of bundling nvcomp #16946
Use nvcomp wheel instead of bundling nvcomp #16946
Conversation
@bdice I've applied your suggestions to rapidsai/kvikio#478 too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one question on the CMake variable name.
/merge |
Note that this has broken downstream projects that build from a libcudf installed area since nvcomp is no longer installed alongside libcudf artifacts. See #16986. |
Related to rapidsai/build-planning#33 and rapidsai/build-planning#74 The last use of CMake function `install_aliased_imported_targets()` here was removed in #16946. This proposes removing the file holding its definition. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #17276
Description
Contributes to https://github.com/rapidsai/rapids-wheels-planning/issues/74
Checklist