Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Ubuntu 24.04 in CI workflows. #16998

Closed
wants to merge 5 commits into from

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Oct 4, 2024

This PR tests Ubuntu 24.04 in CI workflows. See rapidsai/shared-workflows#248.

Contributes to rapidsai/build-planning#74.

@bdice bdice added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function 5 - DO NOT MERGE Hold off on merging; see PR for details labels Oct 4, 2024
@bdice
Copy link
Contributor Author

bdice commented Oct 8, 2024

An issue I see here is that Ubuntu 24.04 has different tzdata than previous releases. We get errors like:

FAILED tests/test_orc.py::test_orc_reader_datetimestamp[TestOrcFile.testDate1900.orc-False] - RuntimeError: CUDF failure at: /opt/conda/conda-bld/work/cpp/src/datetime/timezone.cpp:141: Failed to open the timezone file.
FAILED tests/test_orc.py::test_orc_reader_datetimestamp[TestOrcFile.testDate1900.orc-True] - RuntimeError: CUDF failure at: /opt/conda/conda-bld/work/cpp/src/datetime/timezone.cpp:141: Failed to open the timezone file.
FAILED tests/test_orc.py::test_orc_reader_datetimestamp[TestOrcFile.testDate2038.orc-False] - RuntimeError: CUDF failure at: /opt/conda/conda-bld/work/cpp/src/datetime/timezone.cpp:141: Failed to open the timezone file.
FAILED tests/test_orc.py::test_orc_reader_datetimestamp[TestOrcFile.testDate2038.orc-True] - RuntimeError: CUDF failure at: /opt/conda/conda-bld/work/cpp/src/datetime/timezone.cpp:141: Failed to open the timezone file.
FAILED tests/test_orc.py::test_orc_read_stripes[cudf] - RuntimeError: CUDF failure at: /opt/conda/conda-bld/work/cpp/src/datetime/timezone.cpp:141: Failed to open the timezone file.

Here's a diff of the tzdata contents in /usr/share/zoneinfo: https://www.diffchecker.com/yVd6E76w/

We may need to update our test files.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Oct 16, 2024
@bdice
Copy link
Contributor Author

bdice commented Oct 16, 2024

I filed an upstream issue because this problem appears to be affecting several libraries. apache/orc#2049

rapids-bot bot pushed a commit that referenced this pull request Oct 16, 2024
@bdice
Copy link
Contributor Author

bdice commented Oct 22, 2024

Testing is complete. rapidsai/shared-workflows#248 has been merged, so we can close this.

The timezone path error message was handled in #17102.

@bdice bdice closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant