Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Exception message when opening timezone file should contain timezone name #8795

Closed
jlowe opened this issue Jul 20, 2021 · 5 comments · Fixed by #17102
Closed

[FEA] Exception message when opening timezone file should contain timezone name #8795

jlowe opened this issue Jul 20, 2021 · 5 comments · Fixed by #17102
Assignees
Labels
cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS

Comments

@jlowe
Copy link
Member

jlowe commented Jul 20, 2021

Is your feature request related to a problem? Please describe.
While trying to load an ORC file with libcudf, an exception was thrown that looks like this:

21/07/16 09:37:30 WARN TaskSetManager: Lost task 0.0 in stage 0.0 (TID 0) (172.25.0.3 executor 3): ai.rapids.cudf.CudfException: cuDF failure at: /home/jenkins/agent/workspace/jenkins-cudf-release-17-cuda11/cpp/src/io/orc/timezone.cpp:136: Failed to open the timezone file.
        at ai.rapids.cudf.Table.readORC(Native Method)
        at ai.rapids.cudf.Table.readORC(Table.java:829)
        at com.nvidia.spark.rapids.GpuOrcPartitionReader.$anonfun$readToTable$4(GpuOrcScan.scala:853)
[...]

Unfortunately it's not easy to determine which timezone file was causing the error.

Describe the solution you'd like
The exception message thrown when accessing a timezone file should contain the path to the timezone file.

Describe alternatives you've considered
Instead of reporting the full pathname it could report just the timezone name, but having the full path may better help users determine which system package they should install in order to properly process the timezone that appears in the ORC file.

@jlowe jlowe added feature request New feature or request Needs Triage Need team to review and classify libcudf Affects libcudf (C++/CUDA) code. cuIO cuIO issue Spark Functionality that helps Spark RAPIDS labels Jul 20, 2021
@beckernick beckernick removed the Needs Triage Need team to review and classify label Jul 20, 2021
@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@jlowe
Copy link
Member Author

jlowe commented Nov 15, 2021

Still desired for this to be fixed.

@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@jlowe
Copy link
Member Author

jlowe commented Feb 14, 2022

Still desired.

@bdice
Copy link
Contributor

bdice commented Oct 16, 2024

This will be resolved in #17102.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants