Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug-fix: cudf/io/json.hpp use after move #16609

Merged
merged 1 commit into from
Aug 20, 2024
Merged

bug-fix: cudf/io/json.hpp use after move #16609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cpp/include/cudf/io/json.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,6 +696,8 @@ class json_writer_options_builder;
class json_writer_options {
// Specify the sink to use for writer output
sink_info _sink;
// maximum number of rows to write in each chunk (limits memory use)
size_type _rows_per_chunk = std::numeric_limits<size_type>::max();
// Set of columns to output
table_view _table;
// string to use for null entries
Expand All @@ -704,8 +706,6 @@ class json_writer_options {
bool _include_nulls = false;
// Indicates whether to use JSON lines for records format
bool _lines = false;
// maximum number of rows to write in each chunk (limits memory use)
size_type _rows_per_chunk = std::numeric_limits<size_type>::max();
// string to use for values != 0 in INT8 types (default 'true')
std::string _true_value = std::string{"true"};
// string to use for values == 0 in INT8 types (default 'false')
Expand All @@ -720,7 +720,7 @@ class json_writer_options {
* @param table Table to be written to output
*/
explicit json_writer_options(sink_info sink, table_view table)
: _sink(std::move(sink)), _table(std::move(table)), _rows_per_chunk(table.num_rows())
: _sink(std::move(sink)), _rows_per_chunk(table.num_rows()), _table(std::move(table))
{
}

Expand Down
Loading