Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug-fix: cudf/io/json.hpp use after move #16609

Merged
merged 1 commit into from
Aug 20, 2024
Merged

bug-fix: cudf/io/json.hpp use after move #16609

merged 1 commit into from
Aug 20, 2024

Conversation

NicolasDenoyelle
Copy link
Contributor

@NicolasDenoyelle NicolasDenoyelle commented Aug 19, 2024 •
edited by vyasr
Loading

Description

This PR fixes a use after move in json header.
The fix simply shifts the attributes to access the object value before moving it.
Closes #16608

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@NicolasDenoyelle NicolasDenoyelle requested a review from a team as a code owner August 19, 2024 21:39
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 19, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 19, 2024
@NicolasDenoyelle NicolasDenoyelle changed the title MINOR: Fix use after move bug: Fix use after move Aug 19, 2024
@NicolasDenoyelle NicolasDenoyelle changed the title bug: Fix use after move bug-fix: cudf/io/json.hpp use after move Aug 19, 2024
bdice
bdice approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an appropriate fix to me. Thanks!

@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change bug Something isn't working and removed improvement Improvement / enhancement to an existing function labels Aug 19, 2024
@bdice
Copy link
Contributor

bdice commented Aug 19, 2024

/ok to test

@ttnghia
Copy link
Contributor

ttnghia commented Aug 20, 2024

/merge

@rapids-bot rapids-bot bot merged commit 2f7d354 into rapidsai:branch-24.10 Aug 20, 2024
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@mhaseeb123 mhaseeb123 mhaseeb123 approved these changes

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Method called on moved-from object (json.hpp:723:73)
5 participants
@NicolasDenoyelle @bdice @ttnghia @mhaseeb123 @davidwendt