Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide all gtest symbols in cudftestutil #16546

Merged
merged 7 commits into from
Aug 15, 2024
Merged

Hide all gtest symbols in cudftestutil #16546

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f2c91d1
Hide all gtest symbols in cudftestutil
robertmaynard Aug 12, 2024
2d1b10f
Merge branch 'branch-24.10' into bug/dont_expose_gtest_symbols_in_cud…
robertmaynard Aug 13, 2024
9e87b08
Correct issues found by CI
robertmaynard Aug 13, 2024
c688e5d
Update cpp/cmake/thirdparty/get_gtest.cmake
robertmaynard Aug 13, 2024
77c670f
Update cpp/cmake/thirdparty/get_gtest.cmake
robertmaynard Aug 13, 2024
ddf7706
Correct style issues found by CI
robertmaynard Aug 13, 2024
9c0ee45
Merge branch 'branch-24.10' into bug/dont_expose_gtest_symbols_in_cud…
robertmaynard Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions cpp/cmake/thirdparty/get_gtest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,20 @@
function(find_and_configure_gtest)
include(${rapids-cmake-dir}/cpm/gtest.cmake)

# Mark all the non explicit googletest symbols as hidden
# This ensures that libcudftestutil can be used by consumers with a different
# shared gtest
set(gtest_hide_internal_symbols ON)

# Find or install GoogleTest
rapids_cpm_gtest(BUILD_STATIC)

# Mark all the explicit googletest symbols as hidden
# This ensures that libcudftestutil can be used by consumers with a different
# shared gtest
if(TARGET gtest)
target_compile_definitions(gtest PUBLIC "$<BUILD_LOCAL_INTERFACE:GTEST_API_=>")
endif()
endfunction()

find_and_configure_gtest()
Loading