Hide all gtest symbols in cudftestutil #16546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By hiding the gtest symbols in cudftestutil it allows consumers of the library to build with a differing version of gtest without issue.
robertmaynard
added
bug
github-actions
bot
added
libcudf
cryos
approved these changes
Aug 13, 2024
bdice
approved these changes
Aug 13, 2024
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
|
/merge |
robertmaynard
deleted the
bug/dont_expose_gtest_symbols_in_cudftestutil_
branch
robertmaynard
added a commit
to robertmaynard/cudf
that referenced
this pull request
Aug 22, 2024
This reverts commit ac42bc8.
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
This reverts commit ac42bc8. We need to revert #16546 as it broke the gtest builds for cudf. Therefore gtests that actually fail wouldn't properly report an error but silently continue and report as passed. Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr) URL: #16644
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By hiding the gtest symbols in cudftestutil it allows consumers of the library to build with a differing version of gtest without issue.
Checklist