Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix operator precedence problem in Parquet reader #15638

Merged
merged 1 commit into from
May 2, 2024
Merged

Fix operator precedence problem in Parquet reader #15638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/src/io/parquet/page_decode.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ struct null_count_back_copier {
*/
constexpr bool is_string_col(PageInfo const& page, device_span<ColumnChunkDesc const> chunks)
{
if (page.flags & PAGEINFO_FLAGS_DICTIONARY != 0) { return false; }
if ((page.flags & PAGEINFO_FLAGS_DICTIONARY) != 0) { return false; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or just this:

Suggested change
if ((page.flags & PAGEINFO_FLAGS_DICTIONARY) != 0) { return false; }
if (page.flags & PAGEINFO_FLAGS_DICTIONARY) { return false; }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but that's implicit conversion and I don't like that :)

auto const& col = chunks[page.chunk_idx];
return is_string_col(col);
}
Expand Down
Loading