Fix operator precedence problem in Parquet reader #15638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etseidl
changed the title
bdice
approved these changes
May 2, 2024
davidwendt
added
bug
|
/ok to test |
vuule
approved these changes
May 2, 2024
ttnghia
approved these changes
May 2, 2024
|
/merge |
Yes. My guess is this was an attempt to clean up a |
ttnghia
reviewed
May 2, 2024
| @@ -122,7 +122,7 @@ struct null_count_back_copier { | |||
| */ | |||
| constexpr bool is_string_col(PageInfo const& page, device_span<ColumnChunkDesc const> chunks) | |||
| { | |||
| if (page.flags & PAGEINFO_FLAGS_DICTIONARY != 0) { return false; } | |||
| if ((page.flags & PAGEINFO_FLAGS_DICTIONARY) != 0) { return false; } | |||
There was a problem hiding this comment.
Or just this:
Suggested change
| if ((page.flags & PAGEINFO_FLAGS_DICTIONARY) != 0) { return false; } | |
| if (page.flags & PAGEINFO_FLAGS_DICTIONARY) { return false; } |
There was a problem hiding this comment.
but that's implicit conversion and I don't like that :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an operator precedence problem with a bitwise
&that was not detected because it was accidentally correct.PAGEINFO_FLAGS_DICTIONARYhas a value of '1', soPAGEINFO_FLAGS_DICTIONARY != 0evaluates to '1', and that ANDed with the page flags evaluatestruewhen the bit is set.Checklist