Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unused variable error/warning in page_data.cu #13093

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Fix unused variable error/warning in page_data.cu #13093

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b8e961
Fix unused variable error/warning in page_data.cu
davidwendt Apr 7, 2023
e1f0002
remove unused variable from gpuOutputBoolean
davidwendt Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions cpp/src/io/parquet/page_data.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,10 +339,11 @@ __device__ void gpuDecodeStream(
* additional values.
*/
template <bool sizes_only>
__device__ cuda::std::pair<int, int> gpuDecodeDictionaryIndices(volatile page_state_s* s,
volatile page_state_buffers_s* sb,
int target_pos,
int t)
__device__ cuda::std::pair<int, int> gpuDecodeDictionaryIndices(
volatile page_state_s* s,
[[maybe_unused]] volatile page_state_buffers_s* sb,
int target_pos,
int t)
{
const uint8_t* end = s->data_end;
int dict_bits = s->dict_bits;
Expand Down Expand Up @@ -524,7 +525,7 @@ __device__ int gpuDecodeRleBooleans(volatile page_state_s* s,
*/
template <bool sizes_only>
__device__ size_type gpuInitStringDescriptors(volatile page_state_s* s,
volatile page_state_buffers_s* sb,
[[maybe_unused]] volatile page_state_buffers_s* sb,
int target_pos,
int t)
{
Expand Down Expand Up @@ -628,13 +629,11 @@ inline __device__ void gpuOutputString(volatile page_state_s* s,
/**
* @brief Output a boolean
*
* @param[in,out] s Page state input/output
* @param[out] sb Page state buffer output
* @param[in] src_pos Source position
* @param[in] dst Pointer to row output data
*/
inline __device__ void gpuOutputBoolean(volatile page_state_s* s,
volatile page_state_buffers_s* sb,
inline __device__ void gpuOutputBoolean(volatile page_state_buffers_s* sb,
int src_pos,
uint8_t* dst)
{
Expand Down Expand Up @@ -2027,7 +2026,7 @@ __global__ void __launch_bounds__(block_size) gpuDecodePageData(
gpuOutputString(s, sb, val_src_pos, dst);
}
} else if (dtype == BOOLEAN) {
gpuOutputBoolean(s, sb, val_src_pos, static_cast<uint8_t*>(dst));
gpuOutputBoolean(sb, val_src_pos, static_cast<uint8_t*>(dst));
} else if (s->col.converted_type == DECIMAL) {
switch (dtype) {
case INT32: gpuOutputFast(s, sb, val_src_pos, static_cast<uint32_t*>(dst)); break;
Expand Down