Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused variable error/warning in page_data.cu #13093

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Fixes a minor compile error/warnings for unused variables in the cpp/src/io/parquet/page_data.cu source file.

cudf/cpp/src/io/parquet/page_data.cu -o CMakeFiles/cudf.dir/src/io/parquet/page_data.cu.o
/cudf/cpp/src/io/parquet/page_data.cu(636): error #177-D: parameter "s" was declared but never referenced

/cudf/cpp/src/io/parquet/page_data.cu(343): error #177-D: parameter "sb" was declared but never referenced
          detected during instantiation of "cuda::std::__4::pair<int, int> cudf::io::parquet::gpu::<unnamed>::gpuDecodeDictionaryIndices<sizes_only>(volatile cudf::io::parquet::gpu::<unnamed>::page_state_s *, volatile cudf::io::parquet::gpu::<unnamed>::page_state_buffers_s *, int, int) [with sizes_only=true]" 
(1720): here

/cudf/cpp/src/io/parquet/page_data.cu(527): error #177-D: parameter "sb" was declared but never referenced
          detected during instantiation of "cudf::size_type cudf::io::parquet::gpu::<unnamed>::gpuInitStringDescriptors<sizes_only>(volatile cudf::io::parquet::gpu::<unnamed>::page_state_s *, volatile cudf::io::parquet::gpu::<unnamed>::page_state_buffers_s *, int, int) [with sizes_only=true]" 
(1724): here

3 errors detected in the compilation of "/cudf/cpp/src/io/parquet/page_data.cu".

Found these with a Debug build using nvcc 11.5 and gcc 9.5.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 7, 2023
@davidwendt davidwendt self-assigned this Apr 7, 2023
@davidwendt davidwendt requested a review from a team as a code owner April 7, 2023 21:21
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit cf26353 into rapidsai:branch-23.06 Apr 10, 2023
@davidwendt davidwendt deleted the debug-unused-warning-115 branch April 10, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants