Fix error in dependencies.yaml causing incomplete pyproject.toml generation #757
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following section of the dependencies.yaml was being ignored:
I noticed this because changing any values here and then running
rapids-dependency-file-generator
did not cause any corresponding change in thepyproject.toml
.The root cause is the files section was defining
py_develop
twice (lines 64 and 72). The first time pointed to the desireddevelop:
section shown above, but the second, duplicate one pointed to thedocs:
section instead. I renamed the second file target topy_docs
to avoid ignoring the developer dependencies section.I tested locally by making changes to the develop: section to verify that they would now show up in the
pyproject.toml
.Ideally we could have
rapids-dependency-file-generator
raise an error or print a warning if duplicate names like this were found.