Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in dependencies.yaml causing incomplete pyproject.toml generation #757

Merged

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Aug 6, 2024

The following section of the dependencies.yaml was being ignored:

  develop:
    common:
      - output_types: [conda, requirements, pyproject]
        packages:
          - pre-commit
          - black
          - ruff
          - isort

I noticed this because changing any values here and then running rapids-dependency-file-generator did not cause any corresponding change in the pyproject.toml.

The root cause is the files section was defining py_develop twice (lines 64 and 72). The first time pointed to the desired develop: section shown above, but the second, duplicate one pointed to the docs: section instead. I renamed the second file target to py_docs to avoid ignoring the developer dependencies section.

I tested locally by making changes to the develop: section to verify that they would now show up in the pyproject.toml.

Ideally we could have rapids-dependency-file-generator raise an error or print a warning if duplicate names like this were found.

@grlee77 grlee77 added the bug Something isn't working label Aug 6, 2024
@grlee77 grlee77 added this to the v24.10.00 milestone Aug 6, 2024
@grlee77 grlee77 requested a review from a team as a code owner August 6, 2024 12:10
@grlee77 grlee77 added the non-breaking Introduces a non-breaking change label Aug 6, 2024
@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 340ac07 into rapidsai:branch-24.10 Aug 6, 2024
45 checks passed
@jakirkham
Copy link
Member

Thanks Greg and Ray! 🙏

@jakirkham
Copy link
Member

Ideally we could have rapids-dependency-file-generator raise an error or print a warning if duplicate names like this were found.

Raised in upstream issue: rapidsai/dependency-file-generator#104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants