Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise on duplicate keys #104

Open
jakirkham opened this issue Aug 6, 2024 · 2 comments
Open

Raise on duplicate keys #104

jakirkham opened this issue Aug 6, 2024 · 2 comments
Labels
feature request New feature or request

Comments

@jakirkham
Copy link
Member

Recently we had an issue in cuCIM where the same key appeared twice ( rapidsai/cucim#757 ). Unfortunately we didn't realize until something didn't behave correctly

It would be helpful to catch these cases in advance by having RDFG raise if it sees duplicate keys

@jakirkham
Copy link
Member Author

cc @grlee77 (who caught this issue)

@jameslamb
Copy link
Member

Just ran into another cases of this: rapidsai/rmm#1613 (comment)

Alternatively, we could roll out something like yamllint across RAPIDS. It has a rule to prevent duplicate keys: https://yamllint.readthedocs.io/en/stable/rules.html#module-yamllint.rules.key_duplicates

That could probably be used for some of the other things I mentioned in #103 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants