Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply bug fix to vendored ndimage code #494

Merged
merged 1 commit into from
Feb 1, 2023
Merged

apply bug fix to vendored ndimage code #494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/cucim/src/cucim/skimage/_vendored/_ndimage_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ def _generate_boundary_condition_ops(mode, ix, xsize, int_t="int",
{ix} %= {xsize};
'''
ops_lower = ops_upper + f'''
if ({ix} < 0) {{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem like this fix should be necessary? I would think the modulus on line 168 makes it so that the xsize should not need to be added more than once.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked about this in comment ( cupy/cupy#7235 (comment) )

while ({ix} < 0) {{
{ix} += {xsize};
}}'''
ops = (ops_lower, ops_upper)
Expand Down