apply bug fix to vendored ndimage code #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grlee77
added
bug
jakirkham
approved these changes
Feb 1, 2023
|
/merge |
grlee77
commented
Feb 1, 2023
| @@ -168,7 +168,7 @@ def _generate_boundary_condition_ops(mode, ix, xsize, int_t="int", | |||
| {ix} %= {xsize}; | |||
| ''' | |||
| ops_lower = ops_upper + f''' | |||
| if ({ix} < 0) {{ | |||
There was a problem hiding this comment.
It doesn't seem like this fix should be necessary? I would think the modulus on line 168 makes it so that the xsize should not need to be added more than once.
There was a problem hiding this comment.
Asked about this in comment ( cupy/cupy#7235 (comment) )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This single line fix was made as part of a larger CUDA 12.0 support PR upstream in CuPy.