add isotropic binary morphology functions #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grlee77
added
feature request
|
rerun tests |
These are based on the distance transform and are a faster way of computing binary morphological operations for large diameter disk or ball footprints. Unlike the sequence footprint decomposition methods, the footprint is exactly circular (spherical).
accidentally had ALL values true rather than ~50% of them
remove unused import
grlee77
force-pushed
the
skimage020-isotropic-binary-morphology
branch
from
de983ab
to
19080b3
Compare
also test isotropic_opening and isotropic_closing with out kwarg
|
Not sure why, but use of the out kwarg causes a failure in only one of the CI test runs. I am trying with an explicit copy instead to see if that resolves it. The test case with the issue appears to be: and then every subsequent test also fails with this same error. |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #419
These are based on the distance transform and are a faster way of computing binary morphological operations for large diameter disk or ball footprints. Unlike the sequence footprint decomposition methods, the footprint is exactly circular (spherical).
One test case
test_isotropic_erosion_spacingwill require #407 to be merged first.#406 will also improve the performance of this implementation