Support sampling kwarg for distance_transform_edt (take pixel/voxel sizes into account)
#407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grlee77
added
improvement
support user-provided output arrays for distances and indices arrays
avoid duplicate shape/dtype checking code
|
@gigony, I added two commits here after your prior review. These were to support the remaining two keyword arguments allowing the user to specify a pre-allocated output array for |
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 29, 2022
related to #419 These are based on the distance transform and are a faster way of computing binary morphological operations for large diameter disk or ball footprints. Unlike the sequence footprint decomposition methods, the footprint is exactly circular (spherical). One test case `test_isotropic_erosion_spacing` will require #407 to be merged first. #406 will also improve the performance of this implementation Authors: - Gregory Lee (https://github.com/grlee77) Approvers: - Gigon Bae (https://github.com/gigony) URL: #421
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review/merge #406 before this one as those changes are also present here.
This PR adds support for anisotropic pixel/voxel shape to
distance_transform_edtvia thesamplingkwarg. The changes involve just making variants of the kernels involving distance computations that do floating-point instead of integer-valued computations so that scaling by the sample spacings can be taken into account.