Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support recursive watch #14

Merged
merged 1 commit into from
Oct 4, 2017
Merged

Support recursive watch #14

merged 1 commit into from
Oct 4, 2017

Conversation

rnbguy
Copy link
Contributor

@rnbguy rnbguy commented Oct 2, 2017 •
edited
Loading

Ref. #10

rnbguy
rnbguy commented Oct 2, 2017
View reviewed changes
wat.go

"gopkg.in/fsnotify.v1"
)

type RecursiveWatcher struct {
Copy link
Contributor Author

@rnbguy rnbguy Oct 2, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be I should put RecursiveWatcher struct in different file. Let me know if that is fine.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem with it 👍

@raphamorim
Copy link
Owner

Nice!
I'll review it til tomorrow night :octocat:

@raphamorim raphamorim merged commit cf78b95 into raphamorim:master Oct 4, 2017
@raphamorim raphamorim mentioned this pull request Oct 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphamorim raphamorim raphamorim left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rnbguy @raphamorim