Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recursive Watch #10

Closed
raphamorim opened this issue Oct 30, 2016 · 5 comments
Closed

Recursive Watch #10

raphamorim opened this issue Oct 30, 2016 · 5 comments
Labels
Hacktoberfest

Comments

@raphamorim
Copy link
Owner

Ref: howeyc/fsnotify#56

Fsnotify doesn't implement recursive file watch. Then I don't know what's the best approach to implement this feature: Use a alternative lib or read/open every folder and apply watchers recursively
@rnbguy
Copy link
Contributor

rnbguy commented Oct 2, 2017 •
edited
Loading

This shouldn't be simple file walk. One has to take care of removing and renaming. I found this --nathany/looper/watch.go which only handles CREATE and WRITE.

If no one is looking into this, I will take a shot.

@raphamorim
Copy link
Owner Author

Nice, If it's easy for you to go on. Be my guest 👍

@rnbguy
Copy link
Contributor

rnbguy commented Oct 2, 2017

I made changes for recursive watch - 05f71d7. I have tested on some simple cases on my Linux machine and it worked fine.

I want to make a PR, so that you can review the code. I am using a different branch. Should I make a PR to your master branch?

@raphamorim
Copy link
Owner Author

Sure! 👍

@rnbguy rnbguy mentioned this issue Oct 2, 2017
Merged
@raphamorim
Copy link
Owner Author

raphamorim commented Oct 4, 2017 •
edited
Loading

Closed by #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raphamorim @rnbguy