[bugfix] resample x and y separately in bootci when paired=False #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several other improvements
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
=======================================
Coverage 98.99% 98.99%
=======================================
Files 19 19
Lines 3287 3294 +7
Branches 523 527 +4
=======================================
+ Hits 3254 3261 +7
Misses 17 17
Partials 16 16
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #276
Also related to #189. At present, it is not possible to use scipy.stats.bootstrap internally because it does not return the bootstrap distribution. Furthermore, the lower-level functions (e.g. BCa, jackknife) are hidden and cannot be imported for external use. For this reason, we cannot add
method="BCa"as a default to Pingouin. The BCa method is only supported for univariate function in SciPy so far.