Skip to content

Commit

Permalink
[bugfix] resample x and y separately in bootci when paired=False (#281)
Browse files Browse the repository at this point in the history
* Fix bootci when paired=False

Several other improvements

* Add vectorization for univariate function

* Updated changelog

* Updated notebook

* Add spearman correlation to unit tests
  • Loading branch information
raphaelvallat authored Jun 19, 2022
1 parent e886add commit 1bc5a86
Show file tree
Hide file tree
Showing 4 changed files with 194 additions and 146 deletions.
9 changes: 4 additions & 5 deletions docs/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,16 @@ What's new

*************

v0.6.0.dev
----------

This is a major release with several API-breaking changes. We recommend all users to upgrade to this new version as soon as possible.
v0.5.2
------

**Bugfixes**

a. The eta-squared (``n2``) effect size was not properly calculated in one-way and two-way repeated measures ANOVAs. Specifically, Pingouin followed the same behavior as JASP, i.e. the eta-squared was the same as the partial eta-squared. However, as explained in `issue 251 <https://github.com/raphaelvallat/pingouin/issues/251>`_, this behavior is not valid. In one-way ANOVA design, the eta-squared should be equal to the generalized eta-squared. Note that, as of March 2022, this bug is also present in JASP. We have therefore updated the unit tests to use JAMOVI instead.

.. warning:: Please make sure to double check any effect sizes previously obtained with the :py:func:`pingouin.rm_anova` function.
.. warning:: Please double check any effect sizes previously obtained with the :py:func:`pingouin.rm_anova` function.

b. Fixed invalid resampling behavior for bivariate functions in :py:func:`pingouin.compute_bootci` when x and y were not paired. `PR 281 <https://github.com/raphaelvallat/pingouin/pull/281>`_.

**Enhancements**

Expand Down
Loading

0 comments on commit 1bc5a86

Please sign in to comment.