Update ProtectedVisibility/PublicVisibility to guard against missing …

…reflection (infection#502)

* Update ProtectedVisibility/PublicVisibility to guard against missing reflection

It seems that PHP-Parser can't provide reflection for anonymous classes yet.

Fixes infection#501 for time being until nikic/PHP-Parser#543 gets fixed.

* PublicVisibility: test for presence of reflection in one place

* Update type hint to include null

src/Mutator/FunctionSignature/ProtectedVisibility.php

@@ -62,9 +62,14 @@ protected function mutatesNode(Node $node): bool
 
     private function hasSameProtectedParentMethod(Node $node): bool
     {
-        /** @var \ReflectionClass $reflection */
+        /** @var \ReflectionClass|null $reflection */
         $reflection = $node->getAttribute(ReflectionVisitor::REFLECTION_CLASS_KEY);
 
+        if (!$reflection instanceof \ReflectionClass) {
+            // assuming the worst where a parent class has the same method
+            return true;
+        }
+
         $parent = $reflection->getParentClass();
 
         while ($parent) {

src/Mutator/FunctionSignature/PublicVisibility.php

@@ -92,14 +92,19 @@ private function isBlacklistedFunction(Node\Identifier $name): bool
 
     private function hasSamePublicParentMethod(Node $node): bool
     {
-        return $this->hasSamePublicMethodInInterface($node) || $this->hasSamePublicMethodInParentClass($node);
+        /** @var \ReflectionClass|null $reflection */
+        $reflection = $node->getAttribute(ReflectionVisitor::REFLECTION_CLASS_KEY);
+
+        if (!$reflection instanceof \ReflectionClass) {
+            // assuming the worst where an interface has the same method
+            return true;
+        }
+
+        return $this->hasSamePublicMethodInInterface($node, $reflection) || $this->hasSamePublicMethodInParentClass($node, $reflection);
     }
 
-    private function hasSamePublicMethodInInterface(Node $node): bool
+    private function hasSamePublicMethodInInterface(Node $node, \ReflectionClass $reflection): bool
     {
-        /** @var \ReflectionClass $reflection */
-        $reflection = $node->getAttribute(ReflectionVisitor::REFLECTION_CLASS_KEY);
-
         foreach ($reflection->getInterfaces() as $reflectionInterface) {
             try {
                 $method = $reflectionInterface->getMethod($node->name->name);
@@ -116,11 +121,8 @@ private function hasSamePublicMethodInInterface(Node $node): bool
         return false;
     }
 
-    private function hasSamePublicMethodInParentClass(Node $node): bool
+    private function hasSamePublicMethodInParentClass(Node $node, \ReflectionClass $reflection): bool
     {
-        /** @var \ReflectionClass $reflection */
-        $reflection = $node->getAttribute(ReflectionVisitor::REFLECTION_CLASS_KEY);
-
         $parent = $reflection->getParentClass();
 
         while ($parent) {

tests/Mutator/FunctionSignature/ProtectedVisibilityTest.php

@@ -179,6 +179,22 @@ private function bar()
     {
     }
 }
+PHP
+        ];
+
+        yield 'it does not mutate an anonymous class because reflection is not avalable' => [
+            <<<'PHP'
+<?php
+
+function something()
+{
+    return new class() {
+        protected function anything()
+        {
+            return null;
+        }
+    };
+}
 PHP
         ];
     }

tests/Mutator/FunctionSignature/PublicVisibilityTest.php

@@ -234,6 +234,22 @@ protected function bar()
     {
     }
 }
+PHP
+        ];
+
+        yield 'it does not mutate an anonymous class because reflection is not avalable' => [
+            <<<'PHP'
+<?php
+
+function something()
+{
+    return new class() {
+        public function anything()
+        {
+            return null;
+        }
+    };
+}
 PHP
         ];
     }