reflectionClass attribute missing on a ClassMethod in an anonymous class

[sanmai]

Consider this code:

function create_date(string $format, string $time): DateTime
{
    return (new class() extends DateTime {
        public static function createFromFormat(string $format, string $time)
        {
            return parent::createFromFormat($format, $time);
        }
    })::createFromFormat($format, $time);
}

createFromFormat follows DateTime's interface in that anonymous class, yet that can't be seen from a reflectionClass attribute as it is missing (NULL).

Complete reproduction case:

<?php
include 'vendor/autoload.php';

$code = <<<'CODE'
<?php

function create_date(string $format, string $time): DateTime
{
    return (new class() extends DateTime {
        public static function createFromFormat(string $format, string $time)
        {
            return parent::createFromFormat($format, $time);
        }
    })::createFromFormat($format, $time);
}

CODE;

$traverser = new PhpParser\NodeTraverser();

$traverser->addVisitor(new class() extends PhpParser\NodeVisitorAbstract {
    public function leaveNode(PhpParser\Node $node): void
    {
        if ($node instanceof PhpParser\Node\Stmt\ClassMethod && $node->isPublic()) {
            echo (new PhpParser\PrettyPrinter\Standard())->prettyPrintFile([$node]);
            $reflection = $node->getAttribute('reflectionClass');

            if ($reflection === null) {
                echo "\n\nNo reflection for a class method!\n";
                exit(1);
            }
        }
    }
});

$traverser->traverse((new PhpParser\ParserFactory())->create(PhpParser\ParserFactory::PREFER_PHP7)->parse($code));

Seems to be relevant to other classes, not just for DateTime.

First seen at infection/infection#501

[nikic]

The reflectionClass attribute is not being added by php-parser. My guess would be that https://github.com/Roave/BetterReflection adds this.

[sanmai]

Oh, thanks! I'll be looking towards there then.

[maks-rafalko]

@sanmai Reflection classes are added by our own visitor https://github.com/infection/infection/blob/master/src/Visitor/ReflectionVisitor.php#L48

[sanmai]

Oh, better and better! This is all my fault! 🤦‍♂️