Windows and Calico support #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
reviewed
Jul 8, 2021
brandond
reviewed
Jul 8, 2021
briandowns
reviewed
Jul 8, 2021
brandond
reviewed
Jul 8, 2021
briandowns
reviewed
Jul 8, 2021
briandowns
reviewed
Jul 8, 2021
briandowns
reviewed
Jul 8, 2021
briandowns
reviewed
Jul 8, 2021
briandowns
reviewed
Jul 8, 2021
briandowns
reviewed
Jul 8, 2021
Oats87
reviewed
Jul 8, 2021
briandowns
reviewed
Jul 8, 2021
briandowns
reviewed
Jul 8, 2021
briandowns
reviewed
Jul 8, 2021
brandond
reviewed
Jul 8, 2021
|
@brandond @briandowns @Oats87 I have pushed up a lot of the changes. |
briandowns
reviewed
Jul 9, 2021
brandond
requested changes
Jul 9, 2021
briandowns
reviewed
Jul 9, 2021
briandowns
reviewed
Jul 9, 2021
briandowns
reviewed
Jul 9, 2021
briandowns
reviewed
Jul 9, 2021
brandond
requested changes
Jul 9, 2021
brandond
reviewed
Jul 13, 2021
Signed-off-by: Jamie Phillips <[email protected]>
This PR adds initial support for windows and calico. Signed-off-by: Jamie Phillips <[email protected]>
luthermonson
changed the title
briandowns
reviewed
Jul 14, 2021
briandowns
approved these changes
Jul 14, 2021
brandond
approved these changes
Jul 14, 2021
luthermonson
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR adds support for Windows agents with Calico as the CNI.
Yes, we should update the documentation to outline the support.
Types of Changes
This adds support for Windows and calico for only windows build targets. The only change that may impact others is the tweak to the clusterrolebinding for the tunnel controller increasing permissions to retrieve the calico token for generating the calico kubeconfig.
Verification
Changes can be verified by passing all existing Linux functionality test. Additionally installing a Windows node with Calico as the CNI hand having the agent join the cluster with a workload deployed that receives an IP from the CNI.
Linked Issues
Further Comments