sql: allow multiple informers to start in parallel #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomleb
reviewed
Sep 6, 2024
moio
force-pushed
the
informer_creation_parallelism
branch
2 times, most recently
from
36edbf4 to
39899ce
Compare
Creating an Informer used to block creation of any other Informers for the whole duration of the warm-up time via one mutex. This patch allows for multiple Informers to be created in parallel, with one mutex per gvk. One overall RWMutex is still kept to avoid races with Reset(). Signed-off-by: Silvio Moioli <[email protected]>
Signed-off-by: Silvio Moioli <[email protected]>
Signed-off-by: Silvio Moioli <[email protected]>
moio
force-pushed
the
informer_creation_parallelism
branch
2 times, most recently
from
4a8a2d8 to
c58211e
Compare
Co-authored-by: Tom Lebreux <[email protected]> Signed-off-by: Silvio Moioli <[email protected]>
Signed-off-by: Silvio Moioli <[email protected]>
moio
force-pushed
the
informer_creation_parallelism
branch
from
c58211e to
2c2f081
Compare
tomleb
reviewed
Sep 20, 2024
Signed-off-by: Silvio Moioli <[email protected]>
tomleb
approved these changes
Sep 21, 2024
aruiz14
approved these changes
Sep 23, 2024
MbolotSuse
approved these changes
Sep 23, 2024
This was referenced Oct 1, 2024
moio
added a commit
to moio/rancher
that referenced
this pull request
Oct 2, 2024
This includes various fixes to the UI Server-Side Pagination experimental feature: https://ranchermanager.docs.rancher.com/how-to-guides/advanced-user-guides/enable-experimental-features/ui-server-side-pagination - rancher/lasso#86 - rancher/lasso#90 - rancher/lasso#85 - rancher/lasso#92 - rancher/lasso#79 - rancher/lasso#97 - rancher/lasso#94 - rancher/lasso#98 - rancher/lasso#108 - rancher/lasso#99 It also includes improvements to code collecting metrics: - rancher/lasso#89 - rancher/lasso#95 And to test code: - rancher/lasso#100 - rancher/lasso#101 Signed-off-by: Silvio Moioli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating an Informer used to block creation of any other Informers for the whole duration of the warm-up time via one mutex.
Warm-up can be long if very many resources are involved, and the behavior blocked any unrelated Steve API calls (eg. UI).
This patch allows for multiple Informers to be created in parallel, with one mutex per gvk.
One overall
RWMutexis still kept to avoid races withReset().best reviewed commit-by-commit
QA notes
This patch allows for the parallelization of the creation of informers and can be verified by looking for "[DEBUG] CacheFor" log messages in rancher debug logs while navigating the UI.
In the example below, note how several Informers start at 9:30:02 and finish at different points in time, with different durations (ConfigMaps is the slowest as it was pre-loaded with 5000 objects).