sql: drop the attachdriver mechanism #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moio
changed the title
|
@pjbgf as agreed this is described in rancher/steve#269 |
After security assessment it was determined storing filterable/sortable columns on disk is acceptable, as none of the information is expected to be sensible. This removes the attachdriver mechanism that created one DB on the disk and another, optionally in memory, as attached DB. Only one DB is created now. This change was driven by the need of dropping the shared cache SQLite mode: https://sqlite.org/sharedcache.html which is in turn needed in order to activate WAL mode, which allows for better performance and less locking (including at CREATE INDEX time). Signed-off-by: Silvio Moioli <[email protected]>
Signed-off-by: Silvio Moioli <[email protected]>
Signed-off-by: Silvio Moioli <[email protected]>
Signed-off-by: Silvio Moioli <[email protected]>
moio
force-pushed
the
drop_attachdriver
branch
2 times, most recently
from
ca518d1 to
9793898
Compare
pjbgf
reviewed
Sep 3, 2024
tomleb
reviewed
Sep 4, 2024
Co-authored-by: Paulo Gomes <[email protected]>
pjbgf
approved these changes
Sep 9, 2024
Signed-off-by: Silvio Moioli <[email protected]>
tomleb
approved these changes
Sep 9, 2024
aruiz14
approved these changes
Sep 10, 2024
MbolotSuse
approved these changes
Sep 10, 2024
moio
added a commit
that referenced
this pull request
Sep 18, 2024
This - sets PRAGMAs correctly, before they were ignored as they used a wrong syntax - removes the `shared=cache` option as #97 removed the need for it - removes the mechanism retrying on SQLITE_BUSY, which is then unnecessary - adds code to issue `BEGIN` on read-only transactions and `BEGIN IMMEDIATE` for transactions expected to write The last point is necessary in order to avoid `SQLITE_BUSY` (5) errors in presence of multiple concurrent writing transactions. Without it `busy_timeout` would not be sufficient, see discussion in #98 Signed-off-by: Silvio Moioli <[email protected]>
This was referenced Oct 1, 2024
moio
added a commit
to moio/rancher
that referenced
this pull request
Oct 2, 2024
This includes various fixes to the UI Server-Side Pagination experimental feature: https://ranchermanager.docs.rancher.com/how-to-guides/advanced-user-guides/enable-experimental-features/ui-server-side-pagination - rancher/lasso#86 - rancher/lasso#90 - rancher/lasso#85 - rancher/lasso#92 - rancher/lasso#79 - rancher/lasso#97 - rancher/lasso#94 - rancher/lasso#98 - rancher/lasso#108 - rancher/lasso#99 It also includes improvements to code collecting metrics: - rancher/lasso#89 - rancher/lasso#95 And to test code: - rancher/lasso#100 - rancher/lasso#101 Signed-off-by: Silvio Moioli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After security assessment it was determined storing filterable/sortable columns on disk is acceptable, as none of the information is expected to be sensible.
This removes the attachdriver mechanism that created one DB on the disk and another, optionally in memory, as attached DB. Only one DB is created now.
This change was driven by the need of dropping the shared cache SQLite mode:
https://sqlite.org/sharedcache.html
which is in turn needed in order to activate WAL mode, which allows for better performance and less locking (including at
CREATE INDEXtime).best reviewed commit-by-commit