Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K3s release improvements #324

Merged
merged 24 commits into from
Jan 5, 2024
Merged

K3s release improvements #324

merged 24 commits into from
Jan 5, 2024

Conversation

tashima42
Copy link
Contributor

@tashima42 tashima42 commented Dec 22, 2023

Changes:

  • Closes: Failed to create RC k3s release #323 adds the missing k3s-io remote to create the PR against.
  • Closes: Add update go version to modify k3s #322 the go version wasn't being updated in the modify command, this was added.
  • Adds macOS support
  • Adds dry run for the modify script
  • Renames OldK3SVersion and NewK3SVersion to OldK3SSuffix and NewK3SSuffix to reflect their usage in the code
  • Renames Token to GithubToken
  • Moves GithubToken out of the config to an env var
  • Adds some customization parameters to run the commands against forks instead of k3s-io

How to test

{
  "old_k8s_version": "v1.27.4",
  "new_k8s_version": "v1.27.5",
  "old_k8s_client": "v0.27.4",
  "new_k8s_client": "v0.27.5",
  "old_k3s_suffix": "k3s1",
  "new_k3s_suffix": "k3s1",
  "release_branch": "release-1.27",
  "workspace": "$GOPATH/src/github.com/kubernetes",
  "handler": "YOURHANDLER",
  "email": "[email protected]",
  "ssh_key_path": "$HOME/.ssh/id_ed25519",
  "k3s_remote": "YOURHANDLER",
  "k8s_rancher_url": "[email protected]:YOURHANDLER/kubernetes.git",
  "k3s_upstream_url": "https://github.com/YOURHANDLER/k3s",
  "dry_run": true
}
cat config-template.json | envsubst > config.json
export GITHUB_TOKEN=your_token
k3s_release create-tags -c config.json
k3s_release push-tags -c config.json
k3s_release modify-k3s -c config.json
k3s_release tag-rc-release -c config.json
k3s_release tag-release -c config.json

@tashima42 tashima42 marked this pull request as ready for review December 26, 2023 17:25
release/k3s/k3s.go Outdated Show resolved Hide resolved
@tashima42 tashima42 requested a review from briandowns January 2, 2024 18:35
@tashima42 tashima42 merged commit 4f95406 into master Jan 5, 2024
2 checks passed
@tashima42 tashima42 deleted the k3s-release-improvements branch January 5, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to create RC k3s release Add update go version to modify k3s
3 participants