Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to create RC k3s release #323

Closed
tashima42 opened this issue Dec 20, 2023 · 0 comments · Fixed by #324
Closed

Failed to create RC k3s release #323

tashima42 opened this issue Dec 20, 2023 · 0 comments · Fixed by #324
Assignees
Labels
bug Something isn't working distro-tools

Comments

@tashima42
Copy link
Contributor

The k3s release creation is failing, the error below is due to a mishandled error, but the issue is being caused by not having the owner set.

opts := &repository.CreateReleaseOpts{
			Repo:         k3sRepo,
			Name:         name,
+                       Owner:        "k3s-io",
			Prerelease:   rc,
			Branch:       r.ReleaseBranch,
			Draft:        !rc,
			ReleaseNotes: "",
		}
➜  ecm-distro-tools ✗ cmd/k3s_release/bin/k3s_release-darwin-arm64 tag-rc-release -c ~/release/k3s/december/v1.26/config-2-26.json
INFO[0000] error: POST https://api.github.com/repos//k3s/releases: 404 Not Found [] 
panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
github.com/rancher/ecm-distro-tools/release/k3s.(*Release).CreateRelease(0x140000e01c0, {0x103530e40, 0x103978e00}, 0x28?, 0x1)
        /Users/pedrosuse/code/rancher/ecm-distro-tools/release/k3s/k3s.go:695 +0x398
main.createRCRelease(0x1400017e420?)
        /Users/pedrosuse/code/rancher/ecm-distro-tools/cmd/k3s_release/tag_rc_release.go:35 +0x134
github.com/urfave/cli/v2.(*Command).Run(0x1400017e420, 0x140000adf80, {0x14000172900, 0x3, 0x3})
        /Users/pedrosuse/go/pkg/mod/github.com/urfave/cli/[email protected]/command.go:274 +0x730
github.com/urfave/cli/v2.(*Command).Run(0x1400017e840, 0x140000addc0, {0x140000ac040, 0x4, 0x4})
        /Users/pedrosuse/go/pkg/mod/github.com/urfave/cli/[email protected]/command.go:267 +0x940
github.com/urfave/cli/v2.(*App).RunContext(0x1400017c000, {0x103530e40?, 0x103978e00}, {0x140000ac040, 0x4, 0x4})
        /Users/pedrosuse/go/pkg/mod/github.com/urfave/cli/[email protected]/app.go:332 +0x518
github.com/urfave/cli/v2.(*App).Run(...)
        /Users/pedrosuse/go/pkg/mod/github.com/urfave/cli/[email protected]/app.go:309
main.main()
        /Users/pedrosuse/code/rancher/ecm-distro-tools/cmd/k3s_release/main.go:38 +0x410
@tashima42 tashima42 self-assigned this Dec 22, 2023
@tashima42 tashima42 added bug Something isn't working distro-tools labels Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working distro-tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant