Refactor ExecutionEngine
#245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralexstokes
force-pushed
the
refactor-ee
branch
2 times, most recently
from
dc26e59 to
1487171
Compare
drop extra implementations we don't necessary need lay the ground work for future forks' implementation
ralexstokes
force-pushed
the
refactor-ee
branch
from
1487171 to
a3bb50d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #178.
This PR lays the ground work for the
ExecutionEnginetype introduced in thebellatrixconsensus specs.It drops some unnecessary baggage to facilitate implementation of future specs.
It does not define a fork-agnostic implementation of
ExecutionEngine. I started sketching this out here https://gist.github.com/ralexstokes/2ae4203c6f6379d956ec588e8744daf0 but will leave it out until we certainly need it.