Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor ExecutionEngine trait #178

Closed
ralexstokes opened this issue Jan 27, 2023 · 0 comments · Fixed by #245
Closed

refactor ExecutionEngine trait #178

ralexstokes opened this issue Jan 27, 2023 · 0 comments · Fixed by #245

Comments

@ralexstokes
Copy link
Owner

bellatrix added an ExecutionEngine trait to support the execution layer added in that fork

however, the implementation is a bit unwieldy if we need to duplicate that definition per-fork, as was done in #168

this is not the end of the world but I believe we can hoist ExecutionEngine to a generic trait parameterized over the ExecutionPayload type and refactor this abstraction

I'm opening this issue to track this refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor ExecutionEngine ralexstokes/ethereum-consensus
1 participant
@ralexstokes